Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud must 'gcloud' must update 'kubectl' before asking 'kubectl' to apply #54

Open
anderskristian opened this issue May 18, 2023 · 3 comments

Comments

@anderskristian
Copy link

anderskristian commented May 18, 2023

It seems like target kube-gke: in kubernetes-gke.mk can risk to use 'kubectl' before 'gcloud' has set current-context.

I have changed that in PR.

Additional I have added single 'properties-local.mk' in 'configuration' directory where the user can assign properties.

properties-local.mk is now used in 'google'

My plan is to use it in more make scripts.

I would like to join the camunda-community-hub

  1. I have signed the https://cla-assistant.io/camunda-community-hub/community

  2. I get below error (because I'm not a member of camunda-community-hub)
    git push --set-upstream origin feature/54
    ERROR: Permission to camunda-community-hub/camunda-8-helm-profiles.git denied to anderskristian.
    fatal: Could not read from remote repository.

  3. So I would like to be granted access to add feature branches to this project

@falko
Copy link
Collaborator

falko commented Jul 5, 2023

Hi @anderskristian,

just fork this repo, push your changes to your fork and create the PR from there.

For joining the Community Hub have a look at https://github.com/camunda-community-hub#how-to-contribute

Cheers,
Falko

@falko
Copy link
Collaborator

falko commented Jul 5, 2023

On the issue: We are not using the --async flag of gcloud container clusters create. So I'd expect that it only returns once the cluster is ready. Did you see it fail?

@falko
Copy link
Collaborator

falko commented Jul 5, 2023

Okay, I think you mean to put the kubectl command to the end of this receipe:
https://github.com/camunda-community-hub/camunda-8-helm-profiles/blob/main/google/include/kubernetes-gke.mk#L26-L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants