From 0dafd1233daf28d7561c44baa4b701f24edecd83 Mon Sep 17 00:00:00 2001
From: Tobias Kohr <tobias.kohr@camptocamp.com>
Date: Mon, 9 Sep 2024 12:06:28 +0200
Subject: [PATCH] fix(markdown-parser): do not apply margin for first
 child/heading

and revert margin/padding changes in html

note: commit overwrites gn-ui css for now. can be removed on next gn-ui update where the bug has been fixed as well
---
 .../dataset/dataset-header/dataset-header.component.html    | 2 +-
 libs/mel/src/lib/text-expand/text-expand.component.html     | 2 +-
 resources/styles.css                                        | 6 ++++++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/apps/datahub/src/app/dataset/dataset-header/dataset-header.component.html b/apps/datahub/src/app/dataset/dataset-header/dataset-header.component.html
index 5676089a..f4022360 100644
--- a/apps/datahub/src/app/dataset/dataset-header/dataset-header.component.html
+++ b/apps/datahub/src/app/dataset/dataset-header/dataset-header.component.html
@@ -41,7 +41,7 @@ <h2 class="mel-section-title mb-6" translate>mel.dataset.abstract</h2>
       [showContent]="fieldReady('abstract')"
     >
       <mel-datahub-text-expand [maxLines]="3"
-        ><div class="sm:block text-2xl pb-8">
+        ><div class="sm:block text-2xl">
           <gn-ui-markdown-parser
             [textContent]="record.abstract"
           ></gn-ui-markdown-parser></div
diff --git a/libs/mel/src/lib/text-expand/text-expand.component.html b/libs/mel/src/lib/text-expand/text-expand.component.html
index 46430865..c8e9a5e9 100644
--- a/libs/mel/src/lib/text-expand/text-expand.component.html
+++ b/libs/mel/src/lib/text-expand/text-expand.component.html
@@ -1,6 +1,6 @@
 <div
   #container
-  class="overflow-hidden transition-[max-height] duration-300 relative"
+  class="overflow-hidden transition-[max-height] duration-300 mb-8 relative"
   [ngClass]="isExpanded || !showToggleButton ? 'ease-in' : 'ease-out'"
   [style.maxHeight]="maxHeight"
 >
diff --git a/resources/styles.css b/resources/styles.css
index a76504a3..066b6172 100644
--- a/resources/styles.css
+++ b/resources/styles.css
@@ -188,3 +188,9 @@ gn-ui-copy-text-button div button {
 gn-ui-copy-text-button div textarea {
   @apply bg-white rounded-l !important;
 }
+
+/** No margin for first markdown child/heading, that cannot be detected by getBoundingClientRect()
+    => can be removed after next gn-ui update **/
+.markdown-body :first-child {
+  margin-top: 0 !important;
+}