Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long vod fails about 2/3 in #11

Open
rak99 opened this issue Sep 19, 2019 · 3 comments
Open

Long vod fails about 2/3 in #11

rak99 opened this issue Sep 19, 2019 · 3 comments

Comments

@rak99
Copy link

rak99 commented Sep 19, 2019

A 9h21m vod fails to complete the 'download chat history' part, and the application just closes around 2/3 in. No error file is produced. Shorter vods have worked for me. It's worth noting that I've reproduced this around 6 times and it always fails at the same %, which is around 66%.

@rak99 rak99 changed the title Long vod just fails about 2/3 in Long vod fails about 2/3 in Sep 19, 2019
@cairthenn
Copy link
Owner

Mind letting me know the video ID so I could look into it?

@rak99
Copy link
Author

rak99 commented Sep 21, 2019

Mind letting me know the video ID so I could look into it?

Certainly, apologies for not including it initially.
The VOD ID is as follows: 482348507

Thank you very much!

@rak99
Copy link
Author

rak99 commented Sep 23, 2019

What could additionally help is to add start/end functionality, twitch supports a start query in the url as far as I know, something like this: ?t=05h18m28s - although I don't know of any end query support or anything like that, although what could be done is (maybe) something like this:
(it might be best to convert it to seconds)

/ -- I have little knowledge of how to program in C# (I think this is in C#)

get startTime from the application interface in either the url field or the 'Start Time' field
get endTime from the application interface in the 'End Time' field

public const int vodDuration = vodLengthInSeconds - (-startTimeInSeconds + endTimeInSeconds);

Should have a var with the timestamp formatted like so: ?t=05h18m28s
Now all you have to do is start the vod at the startTime specified in the application interface,
which twitch supports, and have the download running for the vodDuration, I'm not sure how to check this, I'm a JavaScript developer, so something like might work for me:

call downloadStarted(vodDurationInSeconds) as soon as download is clicked or something...


function downloadInitialization() {
// Do download initiation related stuff
// ---------
// Afterwards
// downloadStarted(vodDurationInSecond);
}

function downloadStarted(vodDurationInSeconds) {
        setTimeout(() => {
            stopDownload();
        }, vodDurationInSeconds);
}

No idea what the C# equivalent of it is, I'm sure you'd know how to do it anyway.
This is likely a lot more complicated than I made it out to be and this might be a waste of time but yeah, just trying to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants