-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BO currently skips "Errors" and "Warnings" on some bookmarked links #234
Comments
So I now figured that the same thing happen for redirections as well, here is a list of links, where bookmarks organizer doesn't "Warnings" their redirected link (some of them can be local to me cuz i'm living in France and they redirect me to their https://www.retroplace.com/ |
From watching your source code, and by making tests with python Not sure how you will react to this, as you are probably more acknowledged on the right HTTP method to use and what not. |
Well I've literally only replaced "HEAD" to "GET" from this file: https://github.com/cadeyrn/bookmarks-organizer/blob/master/src/js/core/background.js#L580 and it fixes all of the "Warnings" not showing up. |
// redirect to identical url. That's weird but there are cases in the real world… 😂 fr I know, I code a similar project and I have that issue as well where people redirect to the same url xD |
I'm currently going to rewrite your source code to fix the issue of the 2 dead links above not outputting as "Errors", you will see it's imo very clean code that I personally uses in my python project. I mean the algorythm. |
Example:
403:
http://new2.fjcdn.com/
404:
http://pre06.deviantart.net/
It doesn't detect those as "Error" I'm sure there are SO many other examples for other http codes. I just don't wanna paste here around 400 results x)
I'm curious, how is currently BO displaying links as "Error" ?
The text was updated successfully, but these errors were encountered: