Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement overlapping timespans incompatibility check #8

Open
jonathan-mayer opened this issue Aug 1, 2024 · 4 comments
Open

Implement overlapping timespans incompatibility check #8

jonathan-mayer opened this issue Aug 1, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jonathan-mayer
Copy link
Member

Issue

Currently the user can set the upscale and downscale periods to overlap, which causes one to be preferred. We want to avoid this priority system.

Problem to solve

There needs to be a check that checks for overlapping timespans between the upscale periods and downscale periods.

Further details

Good Luck

Proposal

Add a check in the checkForIncompatibleFields method of the Layer type, that check for overlapping timespans between upscale and downscale periods.
The check should be able to check for incompatibilities between absolute timespans, relative timespans and between relative and absolute timespans.
It also needs to interpret different timezones, this could propose a bigger issue because of the weekday span on relative timespans.

Who can address the issue

Go Dev

Other links/references

@jonathan-mayer jonathan-mayer added the enhancement New feature or request label Aug 1, 2024
@jonathan-mayer jonathan-mayer changed the title Draft: Implement overlapping timespans incompatibility check Implement overlapping timespans incompatibility check Aug 8, 2024
@jon4skl
Copy link
Contributor

jon4skl commented Aug 8, 2024

@jonathan-mayer @JTaeuber Can one of you please send me the docs about the relative and absolute time again? Just put it in the comments here. Thanks

@JTaeuber
Copy link
Member

JTaeuber commented Aug 8, 2024

Format

Reoccurring/Relative Time

<weekday_from>-<weekday_to> <time_from>-<time_to> <timezone>

e.g.

Mon-Fri 07:30-20:30 Europe/Berlin

Absolute Time

<RFC3339_TIME_FROM> - <RFC3339_TIME_TO>

e.g.

2024-07-29T08:30:00Z - 2024-07-29T16:00:00+02:00

@jonathan-mayer jonathan-mayer linked a pull request Sep 19, 2024 that will close this issue
1 task
@jonathan-mayer jonathan-mayer self-assigned this Feb 11, 2025
@jonathan-mayer
Copy link
Member Author

I had another long look over this today. The only way I see to implement this is complex, hard to understand and relatively compute intensive. We already decided this one is not too important, which is why it's been open for so long. I think we should evaluate/discuss if this is still worth implementing/fixing the version on the old branch.

@jonathan-mayer
Copy link
Member Author

If this gets implemented relative timespans should be refactored with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants