From 4bb823d293e616652cd618c0eab8c3380f2f49d9 Mon Sep 17 00:00:00 2001 From: dboyliao Date: Tue, 25 Feb 2025 13:57:12 +0800 Subject: [PATCH] fix(coinbase): CI build error --- pkg/exchange/coinbase/api/v1/create_order_request.go | 2 +- .../coinbase/api/v1/create_order_request_requestgen.go | 6 +++--- pkg/exchange/coinbase/exchage.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/exchange/coinbase/api/v1/create_order_request.go b/pkg/exchange/coinbase/api/v1/create_order_request.go index 4548e6d4b..0d19e7b26 100644 --- a/pkg/exchange/coinbase/api/v1/create_order_request.go +++ b/pkg/exchange/coinbase/api/v1/create_order_request.go @@ -50,7 +50,7 @@ type CreateOrderRequest struct { stop *string `param:"stop" validValues:"loss,entry"` stopPrice *fixedpoint.Value `param:"stop_price"` price *fixedpoint.Value `param:"price"` - size fixedpoint.Value `param:"size,required"` + size string `param:"size,required"` // don't use fixedpoint.Value because it's required and it will lead to an error in requestgen. funds *fixedpoint.Value `param:"funds"` timeInForce *string `param:"time_in_force" validValues:"GTC,GCC,IOC,FOK"` cancelAfter *string `param:"cancel_after" validValues:"min,hour,day"` diff --git a/pkg/exchange/coinbase/api/v1/create_order_request_requestgen.go b/pkg/exchange/coinbase/api/v1/create_order_request_requestgen.go index d46052ddf..834092ed5 100644 --- a/pkg/exchange/coinbase/api/v1/create_order_request_requestgen.go +++ b/pkg/exchange/coinbase/api/v1/create_order_request_requestgen.go @@ -52,7 +52,7 @@ func (c *CreateOrderRequest) Price(price fixedpoint.Value) *CreateOrderRequest { return c } -func (c *CreateOrderRequest) Size(size fixedpoint.Value) *CreateOrderRequest { +func (c *CreateOrderRequest) Size(size string) *CreateOrderRequest { c.size = size return c } @@ -218,8 +218,8 @@ func (c *CreateOrderRequest) GetParameters() (map[string]interface{}, error) { size := c.size // TEMPLATE check-required - if size == 0 { - return nil, fmt.Errorf("size is required, 0 given") + if len(size) == 0 { + return nil, fmt.Errorf("size is required, empty string given") } // END TEMPLATE check-required diff --git a/pkg/exchange/coinbase/exchage.go b/pkg/exchange/coinbase/exchage.go index 16ecbc377..edfa8341e 100644 --- a/pkg/exchange/coinbase/exchage.go +++ b/pkg/exchange/coinbase/exchage.go @@ -139,7 +139,7 @@ func (e *Exchange) SubmitOrder(ctx context.Context, order types.SubmitOrder) (cr } qty = qty.Mul(ticker.Buy) } - req.Size(qty) + req.Size(qty.String()) // set price if order.Type == types.OrderTypeLimit { req.Price(order.Price)