Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bwrrp/slimdom.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.2.0
Choose a base ref
...
head repository: bwrrp/slimdom.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 15 commits
  • 14 files changed
  • 2 contributors

Commits on Aug 3, 2023

  1. Optionally treat CDATA as normal text (#146)

    This adds an option to parseXmlDocument and parseXmlFragment to treat
    CDATA sections in the input as normal text, outputting (normalized) Text
    nodes instead of CDataSection nodes.
    bwrrp authored Aug 3, 2023
    Copy the full SHA
    a1e88e1 View commit details
  2. 4.3.0

    bwrrp committed Aug 3, 2023
    Copy the full SHA
    2a87390 View commit details

Commits on Oct 19, 2023

  1. Rework prefix resolution during serialization

    This re-implements the algorithms used to determine what prefixes to
    assign and what declarations to output for them during serialization.
    The algorithms in the DOM parsing and serialization spec contain too
    many bugs that have so far not been addressed, and contain complicated
    branching that makes it hard to reason about them.
    
    In the replacement I've tried to remain close to the original behavior
    in spirit. That is, existing prefixes (or, for elements, an inherited
    default namespace) are preferred over authored prefixes but only if they
    are still in scope. Authored prefixes are preferred over generated ones.
    A new prefix is generated only if the authored prefix of an attribute
    conflicts with a declaration on the same element. Declaration attributes
    in the DOM are only preserved if they actually represent a change to the
    namespaces in scope for their element and do not cause conflicts - the
    spec preserved default namespace declarations in a few other cases but
    those seemed unnecessary.
    bwrrp committed Oct 19, 2023
    Copy the full SHA
    eb6c891 View commit details
  2. 4.3.1

    bwrrp committed Oct 19, 2023
    Copy the full SHA
    5e88c8d View commit details
  3. Fix prefix issues

    This fixes attributes being allowed to adopt the default namespace (with
    empty prefix) and ancestor declarations not being considered as
    candidates.
    bwrrp committed Oct 19, 2023
    Copy the full SHA
    c6b199e View commit details
  4. 4.3.2

    bwrrp committed Oct 19, 2023
    Copy the full SHA
    527e54b View commit details

Commits on Dec 21, 2023

  1. Also guard against entity expansion attacks in attribute values (#149)

    Looks like I missed this in the earlier implementation. This refactors the implementation a bit into a shape that also applies to any entities expanded as part of normalizing attribute values, both normal and default.
    bwrrp authored Dec 21, 2023
    Copy the full SHA
    a4f5c76 View commit details
  2. Update devDependencies

    bwrrp committed Dec 21, 2023
    Copy the full SHA
    c6eb97c View commit details
  3. 4.3.3

    bwrrp committed Dec 21, 2023
    Copy the full SHA
    469e950 View commit details

Commits on Mar 15, 2024

  1. Copy the full SHA
    973697b View commit details
  2. Update devDependencies

    bwrrp committed Mar 15, 2024
    Copy the full SHA
    fd1112a View commit details
  3. 4.3.4

    bwrrp committed Mar 15, 2024
    Copy the full SHA
    1e419bf View commit details

Commits on Apr 1, 2024

  1. Downgrade prettier

    Jest isn't compatible with version 3 yet...
    bwrrp committed Apr 1, 2024
    Copy the full SHA
    7d0d7a8 View commit details
  2. Add location info to missing end tag error

    Fixes #151
    bwrrp committed Apr 1, 2024
    Copy the full SHA
    8f38441 View commit details
  3. 4.3.5

    bwrrp committed Apr 1, 2024
    Copy the full SHA
    54255b4 View commit details
Loading