Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deploy_buttonmen_site more user-friendly #3008

Open
2 tasks
cgolubi1 opened this issue Nov 4, 2024 · 0 comments
Open
2 tasks

make deploy_buttonmen_site more user-friendly #3008

cgolubi1 opened this issue Nov 4, 2024 · 0 comments

Comments

@cgolubi1
Copy link
Contributor

cgolubi1 commented Nov 4, 2024

Now that more devs than just me may use this script, let's get a todo list of ways it could make devs' lives easier.

Note: there's a bunch of copy-pasta between deploy_buttonmen_site and the other scripts in its directory like the teardown script. That's not a super high priority to change, but anyone who picks up this issue should make any relevant changes consistently in all scripts, not just the deploy one.

  • Under local use, deploy_buttonmen_site always has docker stand up the site with the http port mapped to 8080 on the host machine. It should be possible to override that if the dev prefers a different port.
  • deploy_buttonmen_site uses sed to change deploy/vagrant/manifests/init.pp to pick up site-specific DB and FQDN parameters. It doesn't undo those changes, which means devs have to manually clean up their workspaces before committing. The script should do the cleanup itself on successful site deploy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant