Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Code128 documentation and example improvements #30

Closed
chrisp60 opened this issue Mar 27, 2024 · 2 comments
Closed

docs: Code128 documentation and example improvements #30

chrisp60 opened this issue Mar 27, 2024 · 2 comments

Comments

@chrisp60
Copy link
Contributor

I feel describing the character sets for Code128 may help other users deal with issues relating to its API.

source

128A (Code Set A) – ASCII characters 00 to 95 (0–9, A–Z and control codes), special characters, and FNC 1–4
128B (Code Set B) – ASCII characters 32 to 127 (0–9, A–Z, a–z), special characters, and FNC 1–4
128C (Code Set C) – 00–99 (encodes two digits with a single code point) and FNC1

I would be happy to make a PR with an excerpt added to the docs and possibly a more descriptive error message.

This is definitely not the responsibility of the library to educate people on the character sets, but also I do not think it would hurt to include.

possibly tangentially related to #20.

@buntine
Copy link
Owner

buntine commented Apr 1, 2024

Thanks, feel free to open a PR for those docs 👍

@buntine
Copy link
Owner

buntine commented Apr 19, 2024

Merged. Thanks!

@buntine buntine closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants