Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: fix the “packing” step for github releases #592

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented Dec 16, 2024

Since the major upgrade of Oclif in #587 we broke the releasing step
of the CLI. This commit updates the release workflow aligning with
the latest suggestion from oclif

Copy link
Member

@Polo2 Polo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Should we update CLI version in readme (cf here) before next github release ?

@paulRbr
Copy link
Member Author

paulRbr commented Dec 16, 2024

Should we update CLI version in readme (cf here) before next github release ?

Good catch thanks!

Since the major upgrade of Oclif in bump-sh#587 we broke the releasing step
of the CLI. This commit updates the release workflow aligning with
the [latest suggestion from oclif](https://github.com/oclif/oclif/blob/458437e5572b496d7eaf84c33b710eaf2f514b33/templates/cli/shared/.github/workflows/onPushToMain.yml.ejs#L14)
@paulRbr paulRbr force-pushed the fix-automated-releases-packs branch from e94135b to 8e5febf Compare December 16, 2024 14:42
@paulRbr paulRbr enabled auto-merge December 16, 2024 14:42
@paulRbr paulRbr merged commit 39f5fda into bump-sh:main Dec 16, 2024
9 checks passed
@paulRbr paulRbr deleted the fix-automated-releases-packs branch December 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants