maintenance: upgrade to TypeScript 5, Oclif 4, node 18+ #587
Conversation
paulRbr
force-pushed
the
upgrade-oclif
branch
4 times, most recently
from
77dae75 to
44d05d9
Compare
paulRbr
changed the title
paulRbr
force-pushed
the
upgrade-oclif
branch
3 times, most recently
from
e9b2a42 to
5bafc68
Compare
paulRbr
force-pushed
the
upgrade-oclif
branch
from
5bafc68 to
b2d0081
Compare
|
feedbacks following live test:
bump preview: all good bump preview: all good bump deploy: all good bump diff : all good bump overlay: all good I'm very impressed by this new version of CLI, well done 👏 |
paulRbr
force-pushed
the
upgrade-oclif
branch
from
b2d0081 to
ca74862
Compare
paulRbr
force-pushed
the
upgrade-oclif
branch
2 times, most recently
from
23801ae to
7dfffad
Compare
As discussed in sync, there was a bug when selecting multiple times the same file: I've fixed the code to only present files that have not yet been selected (and thus the error should not be possible anymore)
Changed the minimal version in the package.json ✅ |
|
@Polo2 could you take a second look and if happy approve the PR 🙏? |
paulRbr
force-pushed
the
upgrade-oclif
branch
from
7dfffad to
f773e15
Compare
Oh oh, looks like someone missed this comment 🙈 |
.github/workflows/checks.yml
Outdated
| @@ -16,7 +16,7 @@ jobs: | |||
| - ubuntu-latest | |||
| - macos-latest | |||
| - windows-latest | |||
| node_version: [ '14', '16', '18' ] | |||
| node_version: [ '18', '20', '23' ] | |||
There was a problem hiding this comment.
in readme we wrote in v20 minimum
The Bump.sh CLI is a node package currently distributed via NPM. This means you must have the Node v20+ interpreter installed on your computer or CI servers.
Does it mean we should remove node_version 18 here?
This is an upgrade of the package description to use a modern version of Typescript and use the latest v4 of oclif. It's basically a whole re-write from a scratch generated oclif package.
paulRbr
force-pushed
the
upgrade-oclif
branch
from
f773e15 to
cce84ae
Compare
Since the major upgrade of Oclif in bump-sh#587 we broke the releasing step of the CLI. This commit updates the release workflow aligning with the [latest suggestion from oclif](https://github.com/oclif/oclif/blob/458437e5572b496d7eaf84c33b710eaf2f514b33/templates/cli/shared/.github/workflows/onPushToMain.yml.ejs#L14)
Since the major upgrade of Oclif in bump-sh#587 we broke the releasing step of the CLI. This commit updates the release workflow aligning with the [latest suggestion from oclif](https://github.com/oclif/oclif/blob/458437e5572b496d7eaf84c33b710eaf2f514b33/templates/cli/shared/.github/workflows/onPushToMain.yml.ejs#L14)
This is a fix after the major upgrade of the CLI (in bump-sh#587) where we broke the interface of the exported core `Diff` class and made its usage as a lib more complicated. Let's align back to what it used to be, and even simplify the interface by making the constructor argument optional.
This is a fix after the major upgrade of the CLI (in bump-sh#587) where we broke the interface of the exported core `Diff` class and made its usage as a lib more complicated. Let's align back to what it used to be, and even simplify the interface by making the constructor argument optional.
This is basically a re-write from scratch using a newly generated package from Oclif v4 due to a too big of a jump from Oclif v1 to oclif v4.
I've then copied files from our CLI one by one making sure compilation (and features) work.
There are still some work to be done:(all done 🎉)Notes for the reviewer
It's a big PR, sorry for that, we can do a pair-review if you feel like it 🤗.
Also, there are a few things I had to adapt in the CLI to make this current upgrade:
I couldn't get theit works!opennode package to work (it was included in oclif's fancy-ux in v1 but isn't part of oclif anymore). This lead me to comment (and thus disable the--openflag features of the CLI)bump preview --liveone) because the mocha test process never ends due to the command “waiting”. I tried with mocking thestdin(as described here) but I don't think an “exit signal” character exists which I can send tostdinto stop the running command. This lead me to comment the related test.Closes #448