-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions #86
Comments
Tracked internally in TCN-61 |
Any news on this? This is currently my main "soft" blocker for implementing message validation (using https://github.com/bufbuild/protoc-gen-validate) Is this being worked on or can I lend a hand here? If so, I'd love some pointers (tried to read through the code generator request => descriptor set creation code but am a bit lost to be honest :-) EDIT: |
Hey Sebastian, |
Yeah, I built my own version of that before I found that in your code :-D. Sorry for the noise. |
@fubhy are you able to share what you've done to get message validation running using |
Just commenting to +1 the issue - my use case would benefit from extension support (specifically, message and field options). |
Support for extensions was just released in v1.7.0. Extensions can be used to retrieve custom Protobuf options from descriptors, for example in a plugin. But it's not possible yet to retrieve options at runtime from generated code. We do have concrete plans for this feature though, and we'll keep the issue #397 updated. |
The docs say:
I don't think we can ignore extensions - what does the core js do?
The text was updated successfully, but these errors were encountered: