Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Only add PR comment in case of a failure #82

Closed
armsnyder opened this issue Dec 11, 2024 · 2 comments
Closed

Request: Only add PR comment in case of a failure #82

armsnyder opened this issue Dec 11, 2024 · 2 comments

Comments

@armsnyder
Copy link

To reduce noise on PRs, we would like if the action only added the PR comment in the case of one of the checks failing. I suggest a new action input like skip_pr_comment_on_success. Alternatively, output the comment markdown as an action output and let the user decide how to handle it.

@nicksnyder
Copy link
Member

nicksnyder commented Dec 11, 2024

Is disabling the PR comment completely by setting pr_comment: false not sufficient to solve the noise problem you have? (The action would still report the check status and annotate the difference with lint/braking errors).

Can think about this. If we do it, I would want to avoid adding another config option, but we might be able to turn pr_comment from book to more of an enum.

Also, hello fellow Snyder 👋🏻😁

@armsnyder
Copy link
Author

Hi @nicksnyder! 👋 Thanks for the quick response. If setting pr_comment: false still keeps the job step summary, then that's good enough for me. I'll close this for now. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants