Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if need to expose any ports #5

Open
anton-kachurin opened this issue Oct 25, 2019 · 1 comment
Open

See if need to expose any ports #5

anton-kachurin opened this issue Oct 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@anton-kachurin
Copy link

https://github.com/bu-ist/apache-shib-sp/blob/master/Dockerfile#L44

@anton-kachurin
Copy link
Author

According to documentation:

The EXPOSE instruction does not actually publish the port. It functions as a type of documentation between the person who builds the image and the person who runs the container, about which ports are intended to be published.

The decision what port to use is supposed to be made by the images that use this image as their parent. If the child image wants to expose only port 443, no need to expose 80 in this image, that will only lead to confusion.

Thus, need to remove that.

@bfenster bfenster added the enhancement New feature or request label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants