Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss of precision of Datum #3

Open
hgrw opened this issue Jan 23, 2019 · 1 comment
Open

Loss of precision of Datum #3

hgrw opened this issue Jan 23, 2019 · 1 comment

Comments

@hgrw
Copy link

hgrw commented Jan 23, 2019

It might be that using XmlRpc causes a loss of precision of the datum (8 digits quantised to 6 in my case), which was causing me issues. Looking into it, I wasn't able to quickly identify the cause (I got as far as looking into XmlRpc::XmlRpcValue::ValueArray), and so just overloaded nh_priv.getParam in geonav_transform.cpp with a vector<double>, which took about 2 minutes. I'm not sure if the loss of precision is a bug or an oversight but updating the source to overload getparam with a vector may be a good idea. This feature has been supported since groovy.

@bsb808
Copy link
Owner

bsb808 commented Jan 23, 2019

Thank you for the comment. That is a little scary if XmlRpc is arbitrarily truncating datum values.

Can you provide any more details on the problem you were having? What were the issues that you observed, i.e., how was the loss in precision observed and can you provide some hints as to how to reproduce the problem?

Are you able to submit a pull request as a way to propose the change?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants