Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golangci-Lint breaking Precommit Workflow action #516

Closed
pharr117 opened this issue Jan 1, 2024 · 1 comment · Fixed by #517
Closed

Golangci-Lint breaking Precommit Workflow action #516

pharr117 opened this issue Jan 1, 2024 · 1 comment · Fixed by #517
Assignees
@pharr117
Labels
bug Something isn't working

Comments

@pharr117
Copy link
Collaborator

pharr117 commented Jan 1, 2024

We need to remove the golangci-lint step from the pre-commit workflow and add it into its own separate workflow:

https://golangci-lint.run/usage/install/#github-actions
@pharr117 pharr117 added the bug Something isn't working label Jan 1, 2024
@pharr117 pharr117 self-assigned this Jan 1, 2024
@pharr117 pharr117 moved this to In Progress in Defiant OSS Jan 1, 2024
@pharr117
Copy link
Collaborator Author

pharr117 commented Jan 1, 2024

This was already done in the cosmos indexer repo, so we just need to replicate it here: bryanlabs/cosmos-indexer-sdk#48

@pharr117 pharr117 mentioned this issue Jan 1, 2024
Merged
@pharr117 pharr117 moved this from In Progress to Done in Defiant OSS May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pharr117 pharr117

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch/rpc block results errors and osmosis v21 bryanlabs/cosmos-tax-cli
1 participant
@pharr117