From 74f9ade4fd2fef342abdbf59cb94f5e740efe67d Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 12:41:21 -0500 Subject: [PATCH 1/9] Create template-data-modeling-pr.md --- template-data-modeling-pr.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 template-data-modeling-pr.md diff --git a/template-data-modeling-pr.md b/template-data-modeling-pr.md new file mode 100644 index 0000000..fb51d73 --- /dev/null +++ b/template-data-modeling-pr.md @@ -0,0 +1,23 @@ +# Overview +_Summarize the goal of your work and what motivated it_ + +# Key changes +- _Describe major updates_ + +# Other notes +- _List open questions and other things your reviewer should know_ + +# Related links +- _List links to related ticket(s)_ +- _(optional) Link to other files and resources, such as specific related reports in a BI tool + +# Checklist +- [ ] All models, whether directly changed by this model or not, run successfully +- [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md) +- [ ] Testing + - [ ] All added/modified models and columns are documented and tested in `schema.yml` files + - [ ] All tests pass **OR** + _Check one:_ + - [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR + - [ ] This PR causes new test failures and there is a plan in place for addressing them + From afd5f8409f12f0fdcc8305bfdc1b1354800bc986 Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 12:42:53 -0500 Subject: [PATCH 2/9] Added missing formatting --- template-data-modeling-pr.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/template-data-modeling-pr.md b/template-data-modeling-pr.md index fb51d73..91d951d 100644 --- a/template-data-modeling-pr.md +++ b/template-data-modeling-pr.md @@ -9,7 +9,7 @@ _Summarize the goal of your work and what motivated it_ # Related links - _List links to related ticket(s)_ -- _(optional) Link to other files and resources, such as specific related reports in a BI tool +- _(optional) Link to other files and resources, such as specific related reports in a BI tool_ # Checklist - [ ] All models, whether directly changed by this model or not, run successfully @@ -20,4 +20,3 @@ _Summarize the goal of your work and what motivated it_ _Check one:_ - [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR - [ ] This PR causes new test failures and there is a plan in place for addressing them - From d0da6bc43f7016a9af659cf61534546faa60f076 Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 15:32:21 -0500 Subject: [PATCH 3/9] Update wording Co-authored-by: Sean Rose --- template-data-modeling-pr.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-data-modeling-pr.md b/template-data-modeling-pr.md index 91d951d..632d7a1 100644 --- a/template-data-modeling-pr.md +++ b/template-data-modeling-pr.md @@ -12,7 +12,7 @@ _Summarize the goal of your work and what motivated it_ - _(optional) Link to other files and resources, such as specific related reports in a BI tool_ # Checklist -- [ ] All models, whether directly changed by this model or not, run successfully +- [ ] All models, whether directly changed by this PR or not, run successfully - [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md) - [ ] Testing - [ ] All added/modified models and columns are documented and tested in `schema.yml` files From a566e5aa1167aa92cadce3657d85166b7749168e Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 15:34:56 -0500 Subject: [PATCH 4/9] Update formatting Co-authored-by: Sean Rose --- template-data-modeling-pr.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-data-modeling-pr.md b/template-data-modeling-pr.md index 632d7a1..15cfa83 100644 --- a/template-data-modeling-pr.md +++ b/template-data-modeling-pr.md @@ -14,7 +14,7 @@ _Summarize the goal of your work and what motivated it_ # Checklist - [ ] All models, whether directly changed by this PR or not, run successfully - [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md) -- [ ] Testing +- [ ] Testing: - [ ] All added/modified models and columns are documented and tested in `schema.yml` files - [ ] All tests pass **OR** _Check one:_ From c9430f5d62741fbff568ec700fb47ea8f036253c Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 15:41:18 -0500 Subject: [PATCH 5/9] Changed the heading levels --- template-data-modeling-pr.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/template-data-modeling-pr.md b/template-data-modeling-pr.md index 15cfa83..a24f8d9 100644 --- a/template-data-modeling-pr.md +++ b/template-data-modeling-pr.md @@ -1,22 +1,22 @@ # Overview _Summarize the goal of your work and what motivated it_ -# Key changes +## Key changes - _Describe major updates_ -# Other notes +## Other notes - _List open questions and other things your reviewer should know_ -# Related links +## Related links - _List links to related ticket(s)_ - _(optional) Link to other files and resources, such as specific related reports in a BI tool_ -# Checklist +## Checklist - [ ] All models, whether directly changed by this PR or not, run successfully - [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md) - [ ] Testing: - [ ] All added/modified models and columns are documented and tested in `schema.yml` files - - [ ] All tests pass **OR** + - [ ] All tests pass **OR** _Check one:_ - [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR - [ ] This PR causes new test failures and there is a plan in place for addressing them From 001ff5ef41bed80a8b76848671a454f7aa2b728e Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 15:47:47 -0500 Subject: [PATCH 6/9] Update formatting Co-authored-by: Sean Rose --- template-data-modeling-pr.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-data-modeling-pr.md b/template-data-modeling-pr.md index a24f8d9..80b6ca7 100644 --- a/template-data-modeling-pr.md +++ b/template-data-modeling-pr.md @@ -1,4 +1,4 @@ -# Overview +## Overview _Summarize the goal of your work and what motivated it_ ## Key changes From 00ee8d8cc3b6757d8796f5ebfc3fb3f2b8735af4 Mon Sep 17 00:00:00 2001 From: Alexis Johnson-Gresham Date: Wed, 20 May 2020 15:48:50 -0500 Subject: [PATCH 7/9] rename and relocate file --- template-data-modeling-pr.md => pr_templates/data_modeling_pr.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename template-data-modeling-pr.md => pr_templates/data_modeling_pr.md (100%) diff --git a/template-data-modeling-pr.md b/pr_templates/data_modeling_pr.md similarity index 100% rename from template-data-modeling-pr.md rename to pr_templates/data_modeling_pr.md From 9c7fbe71d26ada1e03857401d799b6d35d6fc23a Mon Sep 17 00:00:00 2001 From: Alexis Date: Wed, 20 May 2020 15:51:34 -0500 Subject: [PATCH 8/9] Added periods --- pr_templates/data_modeling_pr.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/pr_templates/data_modeling_pr.md b/pr_templates/data_modeling_pr.md index 80b6ca7..dc1d7d3 100644 --- a/pr_templates/data_modeling_pr.md +++ b/pr_templates/data_modeling_pr.md @@ -1,22 +1,22 @@ ## Overview -_Summarize the goal of your work and what motivated it_ +_Summarize the goal of your work and what motivated it._ ## Key changes -- _Describe major updates_ +- _Describe major updates._ ## Other notes -- _List open questions and other things your reviewer should know_ +- _List open questions and other things your reviewer should know._ ## Related links -- _List links to related ticket(s)_ -- _(optional) Link to other files and resources, such as specific related reports in a BI tool_ +- _List links to related ticket(s)._ +- _(optional) Link to other files and resources, such as specific related reports in a BI tool._ ## Checklist -- [ ] All models, whether directly changed by this PR or not, run successfully -- [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md) +- [ ] All models, whether directly changed by this PR or not, run successfully. +- [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md). - [ ] Testing: - - [ ] All added/modified models and columns are documented and tested in `schema.yml` files - - [ ] All tests pass **OR** + - [ ] All added/modified models and columns are documented and tested in `schema.yml` files. + - [ ] All tests pass. **OR** _Check one:_ - - [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR - - [ ] This PR causes new test failures and there is a plan in place for addressing them + - [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR. + - [ ] This PR causes new test failures and there is a plan in place for addressing them. From 780fc806e99f1b181197a09dcf4fe85427cdba18 Mon Sep 17 00:00:00 2001 From: Alexis Johnson-Gresham Date: Wed, 20 May 2020 16:10:54 -0500 Subject: [PATCH 9/9] renamed file for clarity --- pr_templates/{data_modeling_pr.md => dbt_modeling_pr.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename pr_templates/{data_modeling_pr.md => dbt_modeling_pr.md} (100%) diff --git a/pr_templates/data_modeling_pr.md b/pr_templates/dbt_modeling_pr.md similarity index 100% rename from pr_templates/data_modeling_pr.md rename to pr_templates/dbt_modeling_pr.md