Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUMMARY #5

Open
sangjunp4rk opened this issue Dec 2, 2017 · 0 comments
Open

SUMMARY #5

sangjunp4rk opened this issue Dec 2, 2017 · 0 comments

Comments

@sangjunp4rk
Copy link

Summary Grade: Satisfactory

Good job with your code! I really liked the way you clearly organized your html code with whitespace and indentations. It makes your code really easy to navigate and read. Also, I really like the way you used classes and ids to group your sections together. As your code grows in size, this will help organize and manage your website. Excellent start to the Ready program!

I included a few notes in both the html and css files for you to think more critically about. You can find these comments in the issues tab of your github. The most important thing is to add mobile resizing. I know that it can be tedious, but you should try to add mobile resizing so you control how your website looks even on different mobile screens. Some suggestions would be to decrease the size of the images when the screen size decreases or rearrange the layout of the text and images so you don’t have to scroll horizontally to read everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant