Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from C132 -> C133 on macOS via 1.76.x - Nightly (Checking C133) #43474

Open
35 tasks done
LaurenWags opened this issue Jan 24, 2025 · 2 comments
Open
35 tasks done

Upgrade from C132 -> C133 on macOS via 1.76.x - Nightly (Checking C133) #43474

LaurenWags opened this issue Jan 24, 2025 · 2 comments
Labels
OS/Desktop OS/macOS QA Pass-macOS QA/Yes release-notes/exclude tests
Milestone
1.76.x - Nightly

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 24, 2025 •
edited by GeetaSarvadnya
Loading

As per process, QA runs through the following cases to ensure that the major chromium bump that's about to get merged into master doesn't regress the Nightly channel. Once the major chromium bump is merged into master, QA will run through a full manual pass on Windows & Android.

Startup & Components

  • Verify that Brave is only contacting *.brave.com endpoints on first launch using either Charles Proxy, Fiddler, Wireshark or LittleSnitch (or a similar application)
    • Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction
  • Remove the following component folders and ensure that they're being re-downloaded after restarting the browser:
    • afalakplffnnnlkncjhbmahjfjhmlkal: AutoplayWhitelist.dat, ExtensionWhitelist.dat, ReferrerWhitelist.json and Greaselion.json
    • CertificateRevocation
    • gccbbckogglekeggclmmekihdgdpdgoe: (Sponsored New Tab Images)
    • gkboaolpopklhgplhaaiboijnklogmbc: Brave Ad Block List Catalog
    • iodkpdagapdfkphljnddpjlldadblomo: Brave Ad Block Updater
    • mfddibmblmbccpadfndgakiopmmhebop: Brave Ad Block List Catalog
    • Safe Browsing
  • Restart the browser, load brave://components, wait for 8 mins and verify that no component shows any errors

Note: Always double check brave://components to make sure there's no errors/missing version numbers

Upgrade

  • Make sure that data from the last version appears in the new version OK
  • Ensure that brave://version lists the expected Brave & Chromium versions
  • With data from the last version, verify that:
    • Bookmarks on the bookmark toolbar and bookmark folders can be opened
    • Cookies are preserved
    • Installed extensions are retained and work correctly
    • Opened tabs can be reloaded
    • Stored passwords are preserved
    • Sync chain created in previous version is retained
    • Social media-blocking buttons changes are retained
    • Custom filters under brave://settings/shields/filters are retained
    • Custom lists under brave://settings/shields/filters are retained
    • Rewards
      • BAT balance is retained
      • Auto-contribute list is retained
      • Both Tips and Monthly Contributions are retained
      • Panel transactions list is retained
      • Changes to rewards settings are retained
      • Ensure that Auto Contribute is not being enabled when upgrading to a new version if AC was disabled
    • Ads
      • Both Estimated pending rewards & Ad notifications received this month are retained
      • Changes to ads settings are retained
      • Ensure that ads are not being enabled when upgrading to a new version if they were disabled
      • Ensure that ads are not disabled when upgrading to a new version if they were enabled
@LaurenWags LaurenWags added this to the 1.76.x - Nightly milestone Jan 24, 2025
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.76.34 Chromium: 133.0.6943.27 (Official Build) nightly (arm64)
-- | --
Revision | 225d5f135d10df8b1b0c53b22934da5aae14cf28
OS | macOS Version 12.5 (Build 21G72)

@LaurenWags
Copy link
Member Author

LaurenWags commented Jan 24, 2025 •
edited
Loading

Upgrade checks (using x64 .dmg):

Brave | 1.76.34 Chromium: 133.0.6943.27 (Official Build) nightly (x86_64)
-- | --
Revision | 225d5f135d10df8b1b0c53b22934da5aae14cf28
OS | macOS Version 14.7.2 (Build 23H311)

and

Brave | 1.76.37 Chromium: 133.0.6943.27 (Official Build) nightly (x86_64)
-- | --
Revision | b0fac5e429b88a4de04a5b92ba6d453579e524c9
OS | macOS Version 14.7.2 (Build 23H311)

Note, need to be on internal VPN to do the below upgrade checks.

C133 --> C133 on-demand upgrade check - PASSED
  1. Install C133 PR build (see slack)
  2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
  3. Watch logs, confirm no update found (can also visit brave://settings/help but close this tab prior to closing the browser)
  4. Close Brave
  5. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
  6. Relaunch with /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
  7. Navigate to brave://settings/help and ensured that an update has been found/being applied
[59668:259:0124/140106.599505:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast
[59668:259:0124/140106.601651:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[59668:259:0124/140106.602825:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[59668:259:0124/140120.502730:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
  1. Confirm you are prompted to "Relaunch" to get update (note, if you click "Relaunch" button you will relaunch and could potentially pick up a newer Nightly that is on the previous Chromium version. Closing and then relaunching via the terminal will not update you again)
Image

Once relaunched, ensured the correct version was installed as per the following:

Example Example
Image Image

Check deltas:

Example Example
Image Image
C132 --> C133 on-demand upgrade check - PASSED
  1. Install C132 build via https://github.com/brave/brave-browser/releases/tag/v1.76.30
  2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
  3. Watch logs, confirm no update found (can also visit brave://settings/help but close this tab prior to closing the browser)
  4. Close Brave
  5. Relaunch with /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
  6. Navigate to brave://settings/help and ensured that an update has been found/being applied
[58973:259:0124/134621.738799:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast
[58973:259:0124/134621.740566:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[58973:259:0124/134621.741933:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[58973:259:0124/134646.245852:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
  1. Confirm you are prompted to "Relaunch" to get update (see note in first case about this button)
Image

Once relaunched, ensured the correct version was installed as per the following:

Example Example
Image Image
C133 --> C133 background upgrade check - PASSED
  1. Install C133 PR build (see slack)
  2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
  3. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
  4. Close browser
  5. Delete the following:
  • com.brave.Browser.nightly folder from ~/Library/Caches
  • com.brave.Browser.nightly.plist file from ~/Library/Preferences
  • Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[60628:259:0124/174028.606813:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast
[60628:259:0124/174028.608239:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[60628:259:0124/174028.609118:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[60628:259:0124/174042.824783:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version
Image
  1. Confirmed deltas:
Example Example
Image Image
C132 --> C133 background upgrade check - PASSED
  1. Install C132 build via https://github.com/brave/brave-browser/releases/tag/v1.76.30
  2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
  3. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
  4. Close browser
  5. Delete the following:
  • com.brave.Browser.nightly folder from ~/Library/Caches
  • com.brave.Browser.nightly.plist file from ~/Library/Preferences
  • Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. After computer restart, Relaunch with /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
  3. DO NOT navigate to brave://settings/help
  4. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[61043:259:0124/204623.571409:INFO:sparkle_glue.mm(327)] brave update: did finish loading appcast
[61043:259:0124/204623.572985:INFO:sparkle_glue.mm(333)] brave update: did find valid update with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[61043:259:0124/204623.574101:INFO:sparkle_glue.mm(354)] brave update: willDownloadUpdate with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
[61043:259:0124/204644.608064:INFO:sparkle_glue.mm(390)] brave update: will install update on quit with AppcastItem(Date: Fri, 24 Jan 2025 17:40:38 +0000, Version: 1.76.37.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Image

@LaurenWags LaurenWags reopened this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Desktop OS/macOS QA Pass-macOS QA/Yes release-notes/exclude tests
Projects
None yet
Milestone
1.76.x - Nightly
Development

No branches or pull requests
2 participants
@LaurenWags @GeetaSarvadnya