Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.2 BC break to refactor loose data #85

Open
hopeseekr opened this issue Feb 3, 2015 · 2 comments
Open

1.2 BC break to refactor loose data #85

hopeseekr opened this issue Feb 3, 2015 · 2 comments
Labels
Code Quality

Comments

@hopeseekr
Copy link
Contributor

OK,

I propose you change the scope level of all of util's public properties to private. There is very little good reason for the end-dev to ever use them, and if there becomes a need, a getter method can be provided.

This is a minor BC break, so I don't think it'd require an upping of the major version to 2.
@hopeseekr
Copy link
Contributor Author

It looks like the code base has stabilized enough to actually consider this now. What's your opinion?

@brandonwamboldt
Copy link
Owner

Yeah I agree, I'm going to make the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonwamboldt @hopeseekr