Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S6. Reviewing others' annotations #103

Open
2 of 3 tasks
hkir-dev opened this issue Mar 6, 2024 · 1 comment
Open
2 of 3 tasks

S6. Reviewing others' annotations #103

hkir-dev opened this issue Mar 6, 2024 · 1 comment
Labels

Comments

@hkir-dev
Copy link
Collaborator

hkir-dev commented Mar 6, 2024

Epic:

Description

User: Lead scientist on the same project with scientists from Use Case 1 #98 .
Use Case: Annotations are in good shape for AIT99, and I want to review, comment, or dispute them.
What I have:

What I need to know:

Tasks

@hkir-dev hkir-dev moved this to Product Backlog in Taxonomy Development Tools Mar 6, 2024
@dosumis dosumis added the story label Mar 6, 2024
@dosumis dosumis moved this from Product Backlog to EPICS in Taxonomy Development Tools Mar 6, 2024
@dosumis
Copy link
Collaborator

dosumis commented Mar 8, 2024

  • (How) can we make these comments private to the team (e.g., for internal review) or public (e.g., to allow public commentary on our cell sets)?

Under current plans all comments will be visible to anyone with access. We could potentially add a field that indicates comments should be deleted on public release + programatic support for deleting. As public visibility is outside of the control of TDT (it is controlled via GitHub) deleting would have to be part of some SOP for public release. Alternatively, we could just encourage anyone preparing a release to manually review all comments to decide if they should be deleted or released to the public. Note - in either case, comments will remain in the history (Git forgets nothing unless your do really radical things to rewrite git history - something I strongly recommend against).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: EPICS
Development

No branches or pull requests

2 participants