Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More possible issues with vertical-position #95

Open
bertfrees opened this issue Mar 21, 2019 · 3 comments
Open

More possible issues with vertical-position #95

bertfrees opened this issue Mar 21, 2019 · 3 comments
Assignees
@kalaspuffar
Labels
bug In discussion OBFL

Comments

@bertfrees
Copy link
Collaborator

I have made the following test OBFL:

<obfl version="2011-1" xml:lang="en">
  <layout-master name="body" page-width="10" page-height="12" duplex="false">
    <default-template>
      <header/>
      <footer/>
    </default-template>
  </layout-master>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block vertical-align="before" vertical-position="8">
      <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block vertical-align="before" vertical-position="8" margin-bottom="1">
      <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block margin-bottom="1">
      <block vertical-align="before" vertical-position="8" margin-bottom="1">
        <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
      </block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block>
      <block vertical-align="before" vertical-position="8" margin-bottom="1">
        <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
      </block>
      <block>⠉⠉⠉⠉⠉</block>
    </block>
  </sequence>
  <sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block margin-bottom="1">
      <block vertical-align="before" vertical-position="8" margin-bottom="1">
        <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
      </block>
      <block>⠉⠉⠉⠉⠉</block>
    </block>
  </sequence>
</obfl>

which results in this PEF:

<pef>
    <body>
        <volume cols="10" rows="12" rowgap="0" duplex="false">
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                    <row>⠉⠉⠉⠉⠉</row>
                </page>
            </section>
            <section>
                <page>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row>⠿⠿⠿⠿⠿</row>
                    <row/>
                    <row>⠉⠉⠉⠉⠉</row>
                    <row/>
                </page>
            </section>
        </volume>
    </body>
</pef>

@joeha480 Could you change this PEF according to what is expected according to you. The spec is not entirely clear about this. I would think the position of the block with vertical-position should not be affected by the ⠉⠉⠉⠉⠉ block after it. But also the fact that the position is affected by margin-bottom seems a bit strange.

If you can fix the expected output I will try to fix the issue.

Note that my fix for #92 did not fix this issue.
@joeha480
Copy link
Contributor

Counting things that comes after the block is incorrect. However, I do think that the entire block (including margins) should end on the specified line.

<?xml version="1.0" encoding="UTF-8"?>
<pef version="2008-1" xmlns="http://www.daisy.org/ns/2008/pef">
<head>
<meta xmlns:dc="http://purl.org/dc/elements/1.1/">
<dc:format>application/x-pef+xml</dc:format>
<dc:identifier>identifier?</dc:identifier>
<dc:date>2019-05-10</dc:date>
</meta>
</head>
<body>
<volume cols="10" rows="12" rowgap="0" duplex="false">
<section>
<page>
<row>⠉⠉⠉⠉⠉</row>
<row/>
<row/>
<row/>
<row/>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
</page>
</section>
<section>
<page>
<row>⠉⠉⠉⠉⠉</row>
<row/>
<row/>
<row/>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row/>
</page>
</section>
<section>
<page>
<row>⠉⠉⠉⠉⠉</row>
<row/>
<row/>
<row/>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row/>
</page>
</section>
<section>
<page>
<row>⠉⠉⠉⠉⠉</row>
<row/>
<row/>
<row/>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row/>
<row>⠉⠉⠉⠉⠉</row>
</page>
</section>
<section>
<page>
<row>⠉⠉⠉⠉⠉</row>
<row/>
<row/>
<row/>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row>⠿⠿⠿⠿⠿</row>
<row/>
<row>⠉⠉⠉⠉⠉</row>
<row/>
</page>
</section>
</volume>
</body>
</pef>

@bertfrees
Copy link
Collaborator Author

Thanks.
What about collapsed margins? How to count these?

<sequence master="body">
    <block>⠉⠉⠉⠉⠉</block>
    <block margin-bottom="2">
      <block vertical-align="before" vertical-position="8" margin-bottom="1">
        <block>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿<br/>⠿⠿⠿⠿⠿</block>
      </block>
    </block>
    <block>⠉⠉⠉⠉⠉</block>
  </sequence>

Like this?

<page>
   <row>⠉⠉⠉⠉⠉</row>
   <row/>
   <row/>
   <row/>
   <row>⠿⠿⠿⠿⠿</row>
   <row>⠿⠿⠿⠿⠿</row>
   <row>⠿⠿⠿⠿⠿</row>
   <row/>
   <row/>
   <row>⠉⠉⠉⠉⠉</row>
</page>

@kalaspuffar kalaspuffar self-assigned this Jul 31, 2019
@bertfrees
Copy link
Collaborator Author

bertfrees commented Oct 11, 2019 •
edited
Loading

@kalaspuffar Joel said that at least part of this reported behavior is wrong, in other words a bug in Dotify, so maybe interesting for you to look at.

How exactly vertical-position interacts with margins and collapsing of margins needs to be cleared up. I can work on this (OBFL issue braillespecs/obfl#69). I think the solution I will propose is to position the block including the margins at the specified position. Basically what Joel said. This is apparently also how it works in CSS for absolute positioning (specification here). Collapsing margins would work normally, like in the example in my comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalaspuffar kalaspuffar

Labels
bug In discussion OBFL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bertfrees @kalaspuffar @joeha480