Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render empty blocks #49

Open
joeha480 opened this issue Mar 23, 2018 · 4 comments
Open

Render empty blocks #49

joeha480 opened this issue Mar 23, 2018 · 4 comments

Comments

@joeha480
Copy link
Contributor

joeha480 commented Mar 23, 2018

Don't ignore empty OBFL-blocks. A block in the source file that ends without adding any text or starting a nested block should render an empty line.

Note that lots of empty block objects (not the same as OBFL-blocks) are created by the formatter. This is because the OBFL-block hierarchy is flattened in the formatter and each transition in the hierarchy results in a new block object (because it might have different properties). These empty blocks could perhaps be merged unless they have different properties, but that's another story.

@joeha480 joeha480 changed the title Improve processing of empty blocks Render empty blocks May 7, 2018
@joeha480
Copy link
Contributor Author

joeha480 commented May 7, 2018

This shadows some input conversion problems, that should probably be made visible.

@bertfrees
Copy link
Collaborator

Maybe it's easier to implement if you disallow empty blocks? Just an idea.

@bertfrees
Copy link
Collaborator

@bertfrees
Copy link
Collaborator

bertfrees commented Aug 1, 2019

I added the "OBFL" label because we first have to fix this on the specification level. This includes the other issues that are related to empty blocks, namely #48 and braillespecs/obfl#74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants