Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowsEndingVolumeOnHyphen(false) does not work when a volume-transition element is present #46

Open
bertfrees opened this issue Mar 15, 2018 · 2 comments
Open

allowsEndingVolumeOnHyphen(false) does not work when a volume-transition element is present #46

bertfrees opened this issue Mar 15, 2018 · 2 comments
Labels
bug

Comments

@bertfrees
Copy link
Collaborator

A test will follow. I've looked at the code and the problem seems to be that RowGroupDataSource shares data with its copies, so that the rows are not always recomputed when needed. I think I can fix this by making more use of immutability, something I was gonna try anyway for the re-implementation of the "flow into footer" feature.
bertfrees added a commit to daisy/pipeline that referenced this issue Mar 15, 2018
@bertfrees
Adds tests for volume breaking between blocks or words
388107f 
One of the tests demonstrates a bug, namely that
allowsEndingVolumeOnHyphen(false) does not work when a
volume-transition element is present. See
brailleapps/dotify.formatter.impl#46.
@bertfrees bertfrees mentioned this issue Mar 15, 2018
Closed
@joeha480 joeha480 added the bug label Mar 19, 2018
joeha480 pushed a commit that referenced this issue Mar 19, 2018
@bertfrees
Adds tests for volume breaking between blocks or words (closes #47)
af9ac7d 
One of the tests demonstrates a bug, namely that allowsEndingVolumeOnHyphen(false) does not work when a volume-transition element is present. See #46.
@joeha480 joeha480 mentioned this issue Oct 8, 2018
Closed
@kalaspuffar
Copy link
Member

@bertfrees will check that this is solved and close if that is the case.

@bertfrees
Copy link
Collaborator Author

Not solved yet.

@bertfrees bertfrees removed their assignment Aug 1, 2019
@bertfrees bertfrees mentioned this issue Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bertfrees @kalaspuffar @joeha480