diff --git a/.github/workflows/alpine-latest.yml b/.github/workflows/alpine-latest.yml index 4205acdebd..37f0beb21d 100644 --- a/.github/workflows/alpine-latest.yml +++ b/.github/workflows/alpine-latest.yml @@ -19,6 +19,7 @@ jobs: runs-on: ubuntu-latest container: image: alpine:latest +# Needed for TCP FastOpen options: --privileged name: "Alpine (latest)" steps: @@ -27,7 +28,6 @@ jobs: apk add bash cmake samurai gtest-dev autoconf autoconf-archive automake libtool pkgconf make clang17 clang17-analyzer compiler-rt lldb gcc g++ valgrind gdb sudo - name: Checkout c-ares uses: actions/checkout@v4 -# This will fails in a container... - name: "Make sure TCP FastOpen is enabled" run: | sudo sysctl -w net.ipv4.tcp_fastopen=3 @@ -101,7 +101,7 @@ jobs: run: | ./ci/build.sh ./ci/test.sh - - name: "Valgrind: build and test c-ares" + - name: "Valgrind: build and test c-ares (no TCP FastOpen)" env: BUILD_TYPE: "valgrind" TEST_WRAP: "valgrind --leak-check=full" @@ -109,5 +109,6 @@ jobs: CMAKE_TEST_FLAGS: "-DCARES_BUILD_TESTS=ON" TEST_DEBUGGER: none run: | + sudo sysctl -w net.ipv4.tcp_fastopen=3 ./ci/build.sh ./ci/test.sh diff --git a/.github/workflows/ubuntu-2004.yml b/.github/workflows/ubuntu-2004.yml index 2d99099b6d..ed71bf356b 100644 --- a/.github/workflows/ubuntu-2004.yml +++ b/.github/workflows/ubuntu-2004.yml @@ -19,6 +19,7 @@ jobs: runs-on: ubuntu-latest container: image: ubuntu:20.04 +# Needed for TCP FastOpen options: --privileged name: "Ubuntu 20.04" steps: @@ -31,7 +32,6 @@ jobs: apt-get install -y --assume-yes sudo curl wget cmake ninja-build autoconf automake libtool g++ libgmock-dev pkg-config clang clang-tools lldb gdb valgrind - name: Checkout c-ares uses: actions/checkout@v4 -# This will probably fail in a container... - name: "Make sure TCP FastOpen is enabled" run: | sudo sysctl -w net.ipv4.tcp_fastopen=3