From 5b1e796603fab722464b21629d2d2a7d68ec6008 Mon Sep 17 00:00:00 2001 From: Brad House Date: Fri, 3 Jan 2025 09:37:04 -0500 Subject: [PATCH] update tests not marked as Live to use 127.0.0.1 as DNS server so OS doesn't immediately reject test due to knowing the route to the DNS server doesn't exist during connect() --- test/ares-test-live.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/test/ares-test-live.cc b/test/ares-test-live.cc index e23dadfe23..2c4981cfa3 100644 --- a/test/ares-test-live.cc +++ b/test/ares-test-live.cc @@ -671,7 +671,11 @@ VIRT_NONVIRT_TEST_F(DefaultChannelTest, LiveGetNameInfoAllocFail) { VIRT_NONVIRT_TEST_F(DefaultChannelTest, GetSock) { ares_socket_t socks[3] = {ARES_SOCKET_BAD, ARES_SOCKET_BAD, ARES_SOCKET_BAD}; - int bitmask = ares_getsock(channel_, socks, 3); + int bitmask; + + EXPECT_EQ(ARES_SUCCESS, (ares_status_t)ares_set_servers_csv(channel_, "127.0.0.1")); + + bitmask = ares_getsock(channel_, socks, 3); EXPECT_EQ(0, bitmask); bitmask = ares_getsock(channel_, nullptr, 0); EXPECT_EQ(0, bitmask); @@ -708,6 +712,8 @@ TEST_F(LibraryTest, GetTCPSock) { EXPECT_EQ(ARES_SUCCESS, ares_init_options(&channel, &opts, optmask)); EXPECT_NE(nullptr, channel); + EXPECT_EQ(ARES_SUCCESS, (ares_status_t)ares_set_servers_csv(channel, "127.0.0.1")); + ares_socket_t socks[3] = {ARES_SOCKET_BAD, ARES_SOCKET_BAD, ARES_SOCKET_BAD}; int bitmask = ares_getsock(channel, socks, 3); EXPECT_EQ(0, bitmask); @@ -744,6 +750,8 @@ TEST_F(DefaultChannelTest, VerifySocketFunctionCallback) { auto my_functions = VirtualizeIO::default_functions; size_t count = 0; + EXPECT_EQ(ARES_SUCCESS, (ares_status_t)ares_set_servers_csv(channel_, "127.0.0.1")); + my_functions.asocket = [](int af, int type, int protocol, void * p) -> ares_socket_t { EXPECT_NE(nullptr, p); (*reinterpret_cast(p))++;