Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Command line is not escaping quote character for xfce-terminal #3732

Open
uben0 opened this issue Jan 29, 2025 · 0 comments
Open

[Bug]: Command line is not escaping quote character for xfce-terminal #3732

uben0 opened this issue Jan 29, 2025 · 0 comments

Comments

@uben0
Copy link

uben0 commented Jan 29, 2025

Describe the bug

When trying to open the command line on a bottle, if xfce-terminal is the chosen terminal emulator, the invoked command is not properly escaped as it can be seen here:

Command: xfce4-terminal -e 'sh -c '/home/evvie/.local/share/bottles/runners/soda-9.0-1/bin/wine64 cmd'' 
xfce4-terminal: Unknown option "cmd"

Because, here

command = " ".join(self.terminal) % "'sh -c %s'" % f"{command}"
the string interpolation is not escaping the quotes.

To Reproduce

  • Ensure you only have xfce-terminal
  • Launch Bottle from a terminal to see the logs
  • Create a new bottle
  • Click on Tool > Command Line

Package

Flatpak from Flathub

Distribution

NixOs with Xfce

Debugging Information

Official Package: false
Version: '51.17'
DE/WM: xfce
Display:
    X.org: true
    X.org (port): :0.0
    Wayland: false
Graphics:
    vendors:
        amd:
            vendor: amd
            envs:
                DRI_PRIME: '1'
            icd: /run/opengl-driver/share/vulkan/icd.d/radeon_icd.x86_64.json
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 6.12.11
Disk:
    Total: 8033767424
    Free: 8033767424
RAM:
    MemTotal: 15.0GiB
    MemAvailable: 11.7GiB
Bottles_envs: null
Tools and Libraries:
    cabextract: true
    p7zip: true
    patool: true
    glibc_min: '2.40'
    icoextract: true
    pefile: true
    orjson: true
    markdown: true
    ImageMagick: true
    FVS: true
    xdpyinfo: true

Troubleshooting Logs

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant