[Bug]: Dependency vcredist*.exe looks corrupted

[Cyb10101]

Describe the bug

Install a wine dependency (vcredist2022) in a existing bottle.
Maybe crashed because a import not finished or stopped because different checksum.

• Downloaded file [VC_redist.x64.exe] looks corrupted.
• Source cksum: [101b0b9f74cdc6cdbd2570bfe92e302c] downloaded: [a8a68bcc74b5022467f12587baf1ef93]
• (ERROR) Error while running async job: <function BackupManager.import_backup at 0x7fe88aa71620>
• Exception: 'list' object has no attribute 'get'

To Reproduce

Installing Dependency "vcredist2022". But i can't see logs again?!

Package

Flatpak from Flathub

Distribution

Ubuntu 22.04

Debugging Information

Official Package: true
Version: '51.11'
DE/WM: ubuntu
Display:
    X.org: true
    X.org (port): :99.0
    Wayland: false
Graphics:
    vendors:
        amd:
            vendor: amd
            envs:
                DRI_PRIME: '1'
            icd: /usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/radeon_icd.x86_64.json:/usr/lib/i386-linux-gnu/GL/vulkan/icd.d/radeon_icd.i686.json
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 6.5.0-18-generic
Disk:
    Total: 16778854400
    Free: 16778690560
RAM:
    MemTotal: 31.3GiB
    MemAvailable: 18.4GiB
Bottles_envs: null

Troubleshooting Logs

21:34:31 (INFO) Installing dependency [vcredist2022] in bottle [Games-Restore__165]. 
VC_redist.x86.exe (100%) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (13.2MiB/13.2MiB - 30.2MiB)

21:34:32 (INFO) Renaming [VC_redist.x86.exe] to [vcredist2022_x86.exe]. 
21:34:32 (INFO) Launching an executable… 
21:34:32 (INFO) Using EasyAntiCheat runtime 
21:34:32 (INFO) Using BattlEye runtime 
esync: up and running.
wine: RLIMIT_NICE is <= 20, unable to use setpriority safely

##### START: About 20 lines of mesa_shader  #####
Failed to create /home/cyb10101/.var/app/com.usebottles.bottles/data/bottles/bottles/Games__165/cache/mesa_shader for shader cache (Datei oder Verzeichnis nicht gefunden)---disabling.
##### END: About 20 lines of mesa_shader  #####
VC_redist.x64.exe (100%) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (24.2MiB/24.2MiB - 40.7MiB)

21:34:36 (INFO) Renaming [VC_redist.x64.exe] to [vcredist2022_x64.exe]. 
21:34:36 (ERROR) Downloaded file [VC_redist.x64.exe] looks corrupted. 
21:34:36 (ERROR) Source cksum: [101b0b9f74cdc6cdbd2570bfe92e302c] downloaded: [a8a68bcc74b5022467f12587baf1ef93] 
21:34:36 (ERROR) Removing corrupted file [VC_redist.x64.exe]. 
21:34:36 (ERROR) Error while running async job: <function BackupManager.import_backup at 0x7fe88aa71620>
	Exception: 'list' object has no attribute 'get'
 
  File "/app/share/bottles/bottles/backend/utils/threading.py", line 62, in __target
    result = self.task_func(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/share/bottles/bottles/backend/managers/backup.py", line 133, in import_backup
    return BackupManager._import_config_backup(path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/share/bottles/bottles/backend/managers/backup.py", line 142, in _import_config_backup
    if config_load.status and manager.create_bottle_from_config(config_load.data):
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/share/bottles/bottles/backend/managers/manager.py", line 1110, in create_bottle_from_config
    % dep.get("Description", "n/a"),
      ^^^^^^^
Traceback (most recent call last):
  File "/app/share/bottles/bottles/frontend/views/importer.py", line 88, in __finish
    if result.ok:
       ^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'ok'

Additional context

No response

[Cyb10101]

The same thing happened with vcredist2019. However, the checksum is correct when I download the file manually.

Only vcredist2022_x64 is wrong. Maybe something actually broke during the download.

Maybe a try catch is helpful so that the installation is aborted and the user is notified.
Without that, Bottles will essentially remain frozen in place.

• https://github.com/bottlesdevs/dependencies/blob/main/Essentials/vcredist2019.yml
• https://github.com/bottlesdevs/dependencies/blob/main/Essentials/vcredist2022.yml

wget -O vcredist2019_x86.exe https://aka.ms/vs/16/release/VC_redist.x86.exe
wget -O vcredist2019_x64.exe https://aka.ms/vs/16/release/VC_redist.x64.exe

wget -O vcredist2022_x86.exe https://aka.ms/vs/17/release/VC_redist.x86.exe
wget -O vcredist2022_x64.exe https://aka.ms/vs/17/release/VC_redist.x64.exe

echo "744b8a391e7e914c6604a533b50a6db8  vcredist2019_x86.exe Git"
echo "744b8a391e7e914c6604a533b50a6db8  vcredist2019_x86.exe md5sum"
md5sum vcredist2019_x86.exe

echo "e091e9e5ede4161b45b880ccd6e140b0  vcredist2019_x64.exe Git"
echo "e091e9e5ede4161b45b880ccd6e140b0  vcredist2019_x64.exe md5sum"
md5sum vcredist2019_x64.exe

echo "9882a328c8414274555845fa6b542d1e  vcredist2022_x86.exe Git"
echo "9882a328c8414274555845fa6b542d1e  vcredist2022_x86.exe md5sum"
md5sum vcredist2022_x86.exe

echo "101b0b9f74cdc6cdbd2570bfe92e302c  vcredist2022_x64.exe Git"
echo "a8a68bcc74b5022467f12587baf1ef93  vcredist2022_x64.exe md5sum"
md5sum vcredist2022_x64.exe

Installation log:

15:18:13 (INFO) Installing dependency [vcredist2019] in bottle [Games]. 
VC_redist.x86.exe (100%) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (13.2MiB/13.2MiB - 33.0MiB)

15:18:14 (INFO) Renaming [VC_redist.x86.exe] to [vcredist2019_x86.exe]. 
15:18:14 (INFO) Launching an executable… 
15:18:14 (INFO) Using EasyAntiCheat runtime 
15:18:14 (INFO) Using BattlEye runtime 
esync: up and running.
wine: RLIMIT_NICE is <= 20, unable to use setpriority safely
002c:err:wineboot:process_run_key Error running cmd L"C:\\windows\\system32\\winemenubuilder.exe -r" (2).
15:18:17 (WARNING) File [vcredist2019_x64.exe] already exists in temp, skipping. 
15:18:17 (ERROR) Downloaded file [VC_redist.x64.exe] looks corrupted. 
15:18:17 (ERROR) Source cksum: [e091e9e5ede4161b45b880ccd6e140b0] downloaded: [35431d059197b67227cd12f841733539] 
15:18:17 (ERROR) Removing corrupted file [VC_redist.x64.exe]. 

[WasteOfO2]

Hey, I am facing this exact same issue and I have verified that my downloaded checksum always remains the same, implying that the checksum employed within bottles is either incorrect or out of date

Not sure what can be done to override this

[mirkobrombin]

fixed by bottlesdevs/dependencies#219