New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit `FundsEncumbered` only if `buyerEscalationDeposit` is greater than 0 #919

Open

zajck opened this issue Feb 28, 2024 · 0 comments

Member

zajck commented Feb 28, 2024

In escalateDisputeInternal a FundsEncumbered is emitted even if no funds were encumbered (i.e. when DRFee is 0).

boson-protocol-contracts/contracts/protocol/bases/DisputeBase.sol

Line 126 in be6ff08

emit FundsEncumbered(buyerId, exchangeToken, buyerEscalationDeposit, sender);

In other parts of the protocol, we emit it only for non-zero values. Follow the same pattern here.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment