Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch methods gas optimization #524

Open
zajck opened this issue Jan 9, 2023 · 0 comments
Open

Batch methods gas optimization #524

zajck opened this issue Jan 9, 2023 · 0 comments
Labels
enhancement New feature or request Refactor

Comments

@zajck
Copy link
Member

zajck commented Jan 9, 2023

Description:

As already pointed out in #511, expireDisputeBatch calls expireDispute in every loop iteration, therefore it checks if dispute region is paused every time. There are also other examples of the same issue:

  • extendOfferBatch
  • voidOfferBatch
  • completeExchangeBatch

Fixing this requires a bit of refactoring and perhaps a different approach to how internal functions work in this cases.
@zajck zajck changed the title Batch method gas optimization Batch methods gas optimization Jan 9, 2023
@zajck zajck mentioned this issue Jan 9, 2023
Merged
@zajck zajck added enhancement New feature or request Refactor labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zajck