logs: providing info on borg arguments and an approximate shell command

[goebbe]

This issue is not about code execution - it is only about the information in the Vorta logs.

In Vorta 0.10.3 an approximate borg command is provided via the logs, e.g. whenever a backup is created.

There are two issues related to this:

1. Sometimes the shell command in the logs is wrong - and makes debugging of the underlying issue difficult. e.g. see Extra borg arguments with white space raise an error #2164
2. The printed shell command is sometimes not in line with the formatting recommendations of borg - e.g. quotation marks are stripped away internally.

I would like to keep a working shell command in the logs. This proved to be useful in the past for copy/modify/past.

Proposal:

1. new: Print the actual list of command line arguments (cmd) to the logs. (in addition to the shell command)
2. change: Print an approximate shell command (build from cmd) that is in line with the borg formatting recommendations.

TODO: Provide some examples to illustrate the issues.

I would like to get some feedback, on how to proceed.

• Would it be o.k. to print the list with the command line arguments to the logs?
• I have some code pending, which would lead to better formatting - should I provide a pull request?

[m3nu]

Sounds good to me to log this command closer to where it's run.