Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file changed warning: Add message id and path #7080

Closed
sophie-h opened this issue Oct 9, 2022 · 2 comments
Closed

file changed warning: Add message id and path #7080

sophie-h opened this issue Oct 9, 2022 · 2 comments
Assignees
Milestone

Comments

@sophie-h
Copy link
Contributor

sophie-h commented Oct 9, 2022

Why not another issue about "<path>: file changed while we backed it up" 🙃

I don't think any of the existing issues #6622 #6989 #6379 propose a global solution that can avoid this message.

However, I want to treat those warnings differently in Pika Backup. For this, I would like to have a msgid and the file's path. AFAIK there are no warnings with msgid yet but, I don't think that is a problem. Not sure if just adding a path key to the message would be okay?

It would probably be good to do the same thing for 'deleted during backup' or whatever the message is.

Application:

  • Pika supports hourly backups. Files like SQLite of chat apps, or an ongoing Download can cause those warnings quite frequently. Instead of users ignoring all those warnings completely or turning backups off, I'm not alerting the user if there is no warning about the same file an hour later again. It's not 100% secure but much more realistic in practice.
  • Just filter those messages completely if you know what you are doing Opt-out of "file changed" warnings specifically #6379
@ThomasWaldmann
Copy link
Member

will be fixed as part of #7976.

ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Dec 27, 2023
@ThomasWaldmann
Copy link
Member

borg 1.4 fixed by #7976 - please test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants