-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yocto slides improvements #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonin Godard <[email protected]>
Except a small nitpick, LGTM |
We usually instruct to use += in recipes, :append in configuration files. Give the good example in this slide. Signed-off-by: Antonin Godard <[email protected]>
After having feedback from a trainee, it was not clear whether these directory are a convention or a requirement. Use "must be" to make it clear that BitBake only looks there for classes. Signed-off-by: Antonin Godard <[email protected]>
Clarify the difference between the recipe and global classes by showing the are used, either with `inherit` or `INHERIT`. Signed-off-by: Antonin Godard <[email protected]>
Most classes are documented, so link each example to the YP documentation. This can help the trainer in showing that classes are documented and that users do not have to "guess" what their purpose and usage is. Signed-off-by: Antonin Godard <[email protected]>
Since scarthgap bitbake also looks in classes-recipe and classes-global. Signed-off-by: Antonin Godard <[email protected]>
8a62a41
to
25ecd70
Compare
tprrt
approved these changes
Feb 18, 2025
jmarcoscosta
approved these changes
Feb 25, 2025
lucaceresoli
approved these changes
Feb 25, 2025
lucaceresoli
approved these changes
Feb 25, 2025
lucaceresoli
approved these changes
Feb 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits messages