Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News related updates #1588

Open
rbbeeston opened this issue Jan 9, 2025 · 2 comments · May be fixed by #1593
Open

News related updates #1588

rbbeeston opened this issue Jan 9, 2025 · 2 comments · May be fixed by #1593
Assignees
Labels
Feature New feature or request Functionality

Comments

@rbbeeston
Copy link
Member

  1. On the home page where news items are listed, there is no specific mention of the type of news item. Please use the same icons as on the news page.

  2. if a link is off-site, please append it with a "open in new window" icon, and be sure it opens in a new window.

  3. Avatars are being shown with a border. remove border and match avatar settings on the other pages.

  4. Avatars and name mentions should also link to that person's github profile if they have provided a gitub username. (this should also be true site wide)

@rbbeeston rbbeeston converted this from a draft issue Jan 9, 2025
@rbbeeston rbbeeston added Feature New feature or request Functionality labels Jan 9, 2025
@GregKaleka
Copy link
Collaborator

I assume #2 is for both the home page and the news page?

@GregKaleka GregKaleka moved this from Accepted to In Progress in website-v2 Jan 9, 2025
@rbbeeston
Copy link
Member Author

That would be correct. Realistically it should be site wide, but I don't think we have that many off site links.

@GregKaleka GregKaleka linked a pull request Jan 10, 2025 that will close this issue
@GregKaleka GregKaleka moved this from In Progress to In Review in website-v2 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Functionality
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants