From abdf96cf50d0176a5ae81202fd5edb6a3ed217d5 Mon Sep 17 00:00:00 2001
From: bomzheg <bomzheg@gmail.com>
Date: Mon, 28 Oct 2024 09:21:09 +0300
Subject: [PATCH] #106 added few tests

---
 shvatka/core/models/dto/action/keys.py |  2 +-
 shvatka/core/models/dto/scn/level.py   |  4 ++--
 shvatka/core/services/key.py           | 25 ++++++++++--------------
 tests/unit/domain/conditions_test.py   | 27 ++++++++++++++++++++++++++
 4 files changed, 40 insertions(+), 18 deletions(-)
 create mode 100644 tests/unit/domain/conditions_test.py

diff --git a/shvatka/core/models/dto/action/keys.py b/shvatka/core/models/dto/action/keys.py
index 8bc1c915..1833393d 100644
--- a/shvatka/core/models/dto/action/keys.py
+++ b/shvatka/core/models/dto/action/keys.py
@@ -12,7 +12,7 @@
 
 @dataclass(frozen=True)
 class BonusKey:
-    text: str
+    text: SHKey
     bonus_minutes: float
 
     def __eq__(self, other: object) -> bool:
diff --git a/shvatka/core/models/dto/scn/level.py b/shvatka/core/models/dto/scn/level.py
index 42e8b6cd..3e7bcd87 100644
--- a/shvatka/core/models/dto/scn/level.py
+++ b/shvatka/core/models/dto/scn/level.py
@@ -164,14 +164,14 @@ def get_keys(self) -> set[str]:
         result: set[SHKey] = set()
         for condition in self.conditions:
             if isinstance(condition, KeyWinCondition):
-                result.union(condition.keys)
+                result = result.union(condition.keys)
         return result
 
     def get_bonus_keys(self) -> set[BonusKey]:
         result: set[BonusKey] = set()
         for condition in self.conditions:
             if isinstance(condition, KeyBonusCondition):
-                result.union(condition.keys)
+                result = result.union(condition.keys)
         return result
 
     @overload
diff --git a/shvatka/core/services/key.py b/shvatka/core/services/key.py
index daa0e83b..5681bc80 100644
--- a/shvatka/core/services/key.py
+++ b/shvatka/core/services/key.py
@@ -1,12 +1,10 @@
 import logging
-import typing
 from dataclasses import dataclass
 
 
 from shvatka.core.interfaces.dal.game_play import GamePlayerDao
 from shvatka.core.models import dto, enums
 from shvatka.core.models.dto import action
-from shvatka.core.models.dto.action import DecisionType
 from shvatka.core.utils import exceptions
 from shvatka.core.utils.input_validation import is_key_valid
 from shvatka.core.utils.key_checker_lock import KeyCheckerFactory
@@ -76,7 +74,10 @@ async def submit_key(
                 logger.warning("impossible decision here is %s", type(decision))
                 return None
 
-def decision_to_parsed_key(decision: action.KeyDecision | action.BonusKeyDecision | action.WrongKeyDecision) -> dto.ParsedKey:
+
+def decision_to_parsed_key(
+    decision: action.KeyDecision | action.BonusKeyDecision | action.WrongKeyDecision,
+) -> dto.ParsedKey:
     match decision:
         case action.KeyDecision:
             return dto.ParsedKey(
@@ -84,21 +85,15 @@ def decision_to_parsed_key(decision: action.KeyDecision | action.BonusKeyDecisio
                 text=decision.key_text,
             )
         case action.BonusKeyDecision:
-            if decision.type == DecisionType.BONUS_TIME:
-                return dto.ParsedBonusKey(
-                    type_=enums.KeyType.bonus,
-                    text=decision.key_text,
-                    bonus_minutes=decision.key.bonus_minutes,
-                )
-            else:
-                return dto.ParsedKey(
-                    type_=enums.KeyType.wrong,
-                    text=decision.key_text,
-                )
+            return dto.ParsedBonusKey(
+                type_=enums.KeyType.bonus,
+                text=decision.key_text,
+                bonus_minutes=decision.key.bonus_minutes,
+            )
         case action.WrongKeyDecision:
             return dto.ParsedKey(
                 type_=decision.key_type,
                 text=decision.key,
             )
         case _:
-            typing.assert_never(decision)
+            raise NotImplementedError(f"unknown decision type {type(decision)}")
diff --git a/tests/unit/domain/conditions_test.py b/tests/unit/domain/conditions_test.py
new file mode 100644
index 00000000..7df306fa
--- /dev/null
+++ b/tests/unit/domain/conditions_test.py
@@ -0,0 +1,27 @@
+import pytest
+
+from shvatka.core.models.dto.action import keys
+from shvatka.core.models.dto import scn
+from shvatka.core.models.dto import action
+from shvatka.core.utils import exceptions
+
+
+def test_create_one_key():
+    c = scn.Conditions([action.KeyWinCondition({keys.SHKey("SH321")})])
+    assert len(c) == 1
+    assert len(c.get_keys()) == 1
+    assert len(c.get_bonus_keys()) == 0
+    actual = c[0]
+    assert isinstance(actual, action.KeyWinCondition)
+    assert actual.keys == {keys.SHKey("SH321")}
+    assert c.get_keys() == {keys.SHKey("SH321")}
+
+
+def test_create_empty_condition():
+    with pytest.raises(exceptions.LevelError):
+        scn.Conditions([])
+
+
+def test_create_only_bonus_condition():
+    with pytest.raises(exceptions.LevelError):
+        scn.Conditions([action.KeyBonusCondition({keys.BonusKey(text="SH123", bonus_minutes=1)})])