-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify parallel development with separate EC and NC target builds #769
base: master
Are you sure you want to change the base?
Simplify parallel development with separate EC and NC target builds #769
Conversation
I'm not sure if that's a good idea. All scripts that use the target path would have to be checked and adapted if necessary. Does e.g. prodloc still work? |
Good point, I hadn't thought of the other scripts. I have now searched for mentions of However, it is currently not functional because it depends on a file in
|
Ok, but then the call to prodloc must be adapted in the build process. Are you sure that's all? Building the targets (ec/nc,) can be automated and you can pass your own paths there. OK, there's now a lot of benefit, but I don't think you should unnecessarily complicate an already quite complex system. |
Agree - perhaps we should leave this as-is if people are relying on the current names in their automation. I have become used to the SDK-style layout of having an EC and NC target in parallel with minimal effort for switching, but I guess this does not have to be the same for everyone. I'll think about this some more. The fixes to the |
I like the idea to have an easy way to have nc and ec target in parallel, as the change here proposes. The key change in the tool contract is that now target uses gbuild.ec instead of gbuild if -n is not given. The buildbbx is usually usedw ith a full path as in put in automation/script, so the change doesn't matter. |
I could imagine to also introduce a environment variable that is, when set, used to input the path to the target. TARGET_DIR for instance. This then will guide buildbbx for its defaults (instead of LOCAL_ROOT+gbuild) and target where the target is that need to be started. This gives no answer (and is independent) of the question how to separate nc and ec variants. |
….pl script with machine-specific paths
One way of finding the EC and NC variant may be the files
that remember the last locations where Perhaps This way, |
This modifies the
buildbbx.pl
script so that it uses separate default paths for the EC and NC build (gbuild.ec
andgbuild.nc
, respectively). As it already remembers the paths for the two separately, this means that the defaults will usually work fine to maintain two separate targets underlocal
, similar to the directory layout of old Geos SDKs.The
target
command now launches the EC target by default, and can be modified with the-n
switch to launch the NC target instead (analogous topmake -n
), assuming that the default paths are used.Note: I do not have a Linux environment for Geos development, so I was not fully able to test the change to the Linux version of
target
.Closes #700.