Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needletail buffer-redux #34

Open
jianshu93 opened this issue Jul 7, 2024 · 2 comments
Open

needletail buffer-redux #34

jianshu93 opened this issue Jul 7, 2024 · 2 comments

Comments

@jianshu93
Copy link

Hello Jim,

Do you mind update either bio or needletail to rely on a new maintained version of buf-redux (called buffer-redux, here: https://crates.io/crates/buffer-redux/1.0.1) since I hav the following warning when compiling it with newest Rust stable:

warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, partitions v0.2.4

Update on crates.io would be greatly helpful also!

Thanks,

Jianshu

@bluenote-1577
Copy link
Owner

Hi Jianshu, are you compiling the latest rust executable or the library?

When I compile skani v0.2.2, I don't get this issue. But I remember getting this issue for the library, which I haven't updated recently because partitions v0.2.4 had an issue -- but the partitions library was unmaintained, so I couldn't update it.

@jianshu93
Copy link
Author

Hi Jim,

I was using the library, not here the most recent GitHub binary. Maybe we should do something similar to the buffer-redux one, update/upload a new one with a similar name but fix the error due to buf-redux, not sure whether it is worth it. Somebody will have to do it in the future I think since it will not work very soon then the library will also stop working.

Jianshu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants