Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue_small question and potential bug #21

Open
AroneyS opened this issue Nov 22, 2023 · 2 comments
Open

Rescue_small question and potential bug #21

AroneyS opened this issue Nov 22, 2023 · 2 comments

Comments

@AroneyS
Copy link

AroneyS commented Nov 22, 2023

It looks like rescue_small rescues small query sketches but not small reference sketches (see

if query_sketch.marker_seeds.len() < 20 && rescue_small{
). This is a bug, right?

Also, do you have a rough estimate for the number of bp that corresponds to query_sketch.marker_seeds.len() < 20?

@bluenote-1577
Copy link
Owner

Hi @AroneyS,

Thanks for bringing this to my attention. Yes, the current screening algorithm is asymmetric between the queries and references for filtering, possibly giving different results when contigs are small. This appears to be a subtle bug.

This will take a bit of testing, so I'll leave this up and fix it in a bit.

@bluenote-1577
Copy link
Owner

The number of marker seeds is on average, genome size / m, where m is the -m parameter. So by default, approx 20kb genomes or contigs pass the filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants