Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check performance after Part7 restructuring #1895

Closed
rakita opened this issue Dec 5, 2024 · 1 comment
Closed

Check performance after Part7 restructuring #1895

rakita opened this issue Dec 5, 2024 · 1 comment

Comments

@rakita
Copy link
Member

rakita commented Dec 5, 2024

After this PR #1865 performance for snailtracer has degraded by 8%.
Part 6 #1814 (comment): I refs: 429,384,219
Part 7 #1865 (comment): I refs: 464,099,580

It is hard to tell where the change is as a lot of things got touched. Samply of latest code: https://share.firefox.dev/3VqdeZg

Would assume it is related to new Instruction that is now a Trait. There were changes to Stack that could potentially cause this. Or removal of generic SPEC from functions (it is now a runtime check).
@rakita
Copy link
Member Author

rakita commented Jan 27, 2025

Did additional a measurement that showed similar performance for snailtracer.

@rakita rakita closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rakita