Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal handling for yaci-cli is not working as expected #99

Closed
abailly opened this issue Jan 14, 2025 · 2 comments
Closed

Signal handling for yaci-cli is not working as expected #99

abailly opened this issue Jan 14, 2025 · 2 comments
Assignees

Comments

@abailly
Copy link
Contributor

abailly commented Jan 14, 2025

I am experimenting with yaci-cli in native distribution (ie. not using docker), and ran into a couple of minor snags when it comes to signal handling:

  1. it does not handle Ctrl + d EOF signal, which should terminate the interactive session
  2. one needs to Ctrl + C twice in order to quit
  3. it's not possible to interrupt download once it's started with Ctrl + C
$ uname -a
Darwin MacBook-Pro-21.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:19:22 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T8112 arm64

yaci-cli version: 0.10.0-preview5

@satran004
Copy link
Member

satran004 commented Jan 14, 2025

Thanks @abailly for highlighting these issues.

We fixed a similar issue for sub-processes like Node, Ogmios, etc., in this PR: #96. So, for already running sub-processes, the process first kills them (if possible) before restarting.

But, for the main yaci-cli process, we still have some edge cases, as you mentioned.

1, 2: Let me try using a shutdown hook in Java. I think this should resolve the issue.

3: This is a known issue. We will fix it in the next release.

@bkreiser
Copy link

I can confirm that this also doesn't work as expected when you run devkit.sh (docker). One would expect the CTRL-D would exit the session. I am on a MacBook Pro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants