feat: wip on ConfigProvider and integration in settings_v2 #1395
+185
−411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lily-de
reviewed
Feb 26, 2025
| return ( | ||
| <div className="h-screen w-full"> | ||
| <div className="relative flex items-center h-[36px] w-full bg-bgSubtle"></div> | ||
| <ConfigProvider> |
There was a problem hiding this comment.
So nice! Will we expand this out over more of the app so we can have state-controlled UI components anywhere we need?
There was a problem hiding this comment.
Hmm,we could wrap the whole app in it if you think that'd be helpful! I just thought all interactions with it might be from here but hard to say.
There was a problem hiding this comment.
Ideas for things that might need to appear in chat window (some of which are currently provided through context provider or local storage):
- model switch shortcut / model shortlist (bottom RH corner)
- current model (shown in bottom RH corner)
- tokens / cost
- idk if this will be something users will want to configure on-the-fly in the chat window, but thinking time for the latest claude model
lily-de
approved these changes
Feb 26, 2025
alexhancock
force-pushed
the
alexhancock/settings-v2-integration
branch
from
06d2a23 to
58f18e5
Compare
alexhancock
force-pushed
the
alexhancock/settings-v2-integration
branch
from
58f18e5 to
3ac8a15
Compare
|
Feedback addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigProviderwhich can contain an in memory copy of the current state ofconfig.yaml+ functions accessible via auseConfighook to take action on the config via API (upsert value, add/remove extension, etc).ConfigProviderto wrapsettings_v2/SettingsViewso all child components can use the hook.