-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [alpha] Providers grid refactor #1345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui/desktop/src/goosed.ts
Outdated
log.info('Spawn options:', JSON.stringify(spawnOptions, null, 2)); | ||
|
||
// Spawn the goosed process | ||
const goosedProcess = spawn(goosedPath, ['agent'], spawnOptions); |
Check failure
Code scanning / Semgrep OSS
Command Injection via child_process Error
Command Injection via child_process
609ef4a
to
7e81e19
Compare
fd913e5
to
32d7550
Compare
alexhancock
approved these changes
Feb 24, 2025
ui/desktop/src/components/settings/providers/providers/NewProviderSettingsPage.tsx
Show resolved
Hide resolved
ui/desktop/src/components/settings/providers/providers/callbacks/AddProviderParameters.tsx
Show resolved
Hide resolved
ui/desktop/src/components/settings/providers/providers/interfaces/ConfigurationAction.tsx
Show resolved
Hide resolved
...omponents/settings/providers/providers/modals/interfaces/ProviderConfigurationModalProps.tsx
Show resolved
Hide resolved
ui/desktop/src/components/settings/providers/providers/subcomponents/CardActions.tsx
Outdated
Show resolved
Hide resolved
alexhancock
reviewed
Feb 24, 2025
ui/desktop/src/components/settings/providers/providers/callbacks/CallbackRegistry.tsx
Show resolved
Hide resolved
lily-de
commented
Feb 24, 2025
ui/desktop/src/components/settings/providers/providers/subcomponents/CardActions.tsx
Outdated
Show resolved
Hide resolved
…onents/CardActions.tsx remove unnecessary log
lily-de
commented
Feb 24, 2025
lily-de
commented
Feb 24, 2025
ui/desktop/src/components/settings/providers/ConfigureProvidersGrid.tsx
Outdated
Show resolved
Hide resolved
lily-de
commented
Feb 24, 2025
ui/desktop/src/components/settings/providers/providers/subcomponents/CardActions.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of new providers architecture
This also streamlines maintaining shared logic or styling across providers.
<ActionButton>
s inside aProviderCard
) to ensure consistent look and feel.How to view
just run-ui-alpha
Note -- currently buttons do not affect any change, you will just see a success toast pop up to indicate that process for linking callback functions to buttons worked
Details
Terminology
Adding a new provider
Adding a new provider with buttons involves adding a similar relatively small item to a mapping
example
OpenAI
Updating card styling (buttons primarily)
CardHeader
is currently where the green check goes,CardBody
is where other actions/buttons such as editing or adding keys)