refactor: Component hierarchy and code cleanup #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is huge! digging in. |
alexhancock
force-pushed
the
alexhancock/component-hierarchy-cleanup
branch
from
875834f to
c652123
Compare
lily-de
reviewed
Feb 20, 2025
| @@ -0,0 +1,9 @@ | |||
| # Goosey | |||
lily-de
reviewed
Feb 20, 2025
| @@ -101,18 +177,42 @@ export default function App() { | |||
| isSubmitting={isInstalling} | |||
| /> | |||
| )} | |||
| <ModelProvider> | |||
| <ActiveKeysProvider> | |||
There was a problem hiding this comment.
I think removing ActiveKeysProvider and ModelProvider will break how we track configured providers and currently set model
There was a problem hiding this comment.
maybe this got moved somewhere and im just not seeing it
lily-de
reviewed
Feb 20, 2025
| <ErrorBoundary> | ||
| <App /> | ||
| </ErrorBoundary> | ||
| <ModelProvider> |
There was a problem hiding this comment.
nvm re earlier comments i found it! nice
lily-de
approved these changes
Feb 20, 2025
nahiyankhan
approved these changes
Feb 20, 2025
alexhancock
force-pushed
the
alexhancock/component-hierarchy-cleanup
branch
from
c652123 to
0f3066c
Compare
alexhancock
force-pushed
the
alexhancock/component-hierarchy-cleanup
branch
from
0f3066c to
520fad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A major refactor of component hierarchy and code cleanup
renderer.tsx > App.tsx -> ___View.tsxrenderer.tsxonly includes top level context providers/error boundary/etcApp.tsxis now the top level component which manages theview/setViewstateSomethingView.tsxand these are rendered conditionally based on the value ofviewinApp.tsx