feat: consolidate goose settings config #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -646,6 +646,12 @@ pub fn configure_settings_dialog() -> Result<(), Box<dyn Error>> { | |||
|
|
|||
| pub fn configure_goose_mode_dialog() -> Result<(), Box<dyn Error>> { | |||
| let config = Config::global(); | |||
|
|
|||
| // Check if GOOSE_MODE is set as an environment variable | |||
| if std::env::var("GOOSE_MODE").is_ok() { | |||
There was a problem hiding this comment.
do we want to use it with this experiment manager: #1287?
There was a problem hiding this comment.
yes, let's use both and consolidate both under 'Settings'
yingjiehe-xyz
approved these changes
Feb 21, 2025
|
Goose mode as a term doesnt describe what's being configured very well, if it's not too late, we could consider something more along the lines of |
laanak08
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goose config: consolidate
tool outputandgoose modesintoGoose SettingsGOOSE_MODEconfiguration variableGOOSE_CLI_MIN_PRIORITYandGOOSE_MODEmust be configured via config, no env var support