Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propagate external_model_message upwards on errors #1297

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

kalvinnchau
Copy link
Collaborator

  • Attempt to propagate external_model_message.message when we get a 400 Bad Request from databricks provider

ex:

( O)> hi
◓  Evolving ethereal entities...                                                                                                                                          
  2025-02-19T18:48:21.799301Z ERROR goose::agents::truncate: Error: Request failed: Request failed with status: 400 Bad Request. Message: Unknown error
    at crates/goose/src/agents/truncate.rs:279

becomes:

  2025-02-19T18:53:32.354126Z ERROR goose::agents::truncate: Error: Request failed: Request failed with status: 400 Bad Request. Message: Malformed input request: #: subject must not be valid against schema {"required":["messages"]}#/tools/4/name: string [6kr06od8__add nums] does not match pattern ^[a-zA-Z0-9_-]{1,64}$#/tools/4: required key [type] not found#/tools/4: extraneous key [input_schema] is not permitted#/tools/4: extraneous key [description] is not permitted#/tools/4/name: #/tools/4/name: 6kr06od8__add nums is not a valid enum value#/tools/4: required key [type] not found#/tools/4: required key [display_height_px] not found#/tools/4: required key [display_width_px] not found#/tools/4: extraneous key [input_schema] is not permitted#/tools/4: extraneous key [description] is not permitted#/tools/4/name: #/tools/4/name: 6kr06od8__add nums is not a valid enum value#/tools/4: required key [type] not found#/tools/4: extraneous key [input_schema] is not permitted#/tools/4: extraneous key [description] is not permitted#/tools/4/name: 6kr06od8__add nums is not a valid enum value#/tools/4/name: , please reformat your input and try again.
    at crates/goose/src/agents/truncate.rs:279

@kalvinnchau kalvinnchau merged commit a59119b into main Feb 19, 2025
5 checks passed
@kalvinnchau kalvinnchau deleted the kalvin/propagate-error branch February 19, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants