Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace prompt for ollama smaller models #1021

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

michaelneale
Copy link
Collaborator

this takes the prompt from @wendytang's change here: #999 but is only in ollama

- Capture display: `screen_capture(display=0)` # Main display
- Capture window: `screen_capture(window_title="Window Title")`
Info: at the start of the session, the user's directory is:
"#};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either include the cwd or remove the line Info: at the start of the session, the user's directory is:?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should already be there from the developer prompt? (just not replaced)

dev_section.find("### Instructions"),
dev_section.find("operating system:"),
) {
let new_instructions = formatdoc! {r#"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: keep the instructions at the providers/ level so we can keep track of any customizations

@salman1993 salman1993 changed the title replace prompt for ollama smaller models feat: replace prompt for ollama smaller models Feb 6, 2025
@wendytang
Copy link
Collaborator

wendytang commented Feb 6, 2025

tested: qwen asked me to verify with mv, cp, rm commands! good sign
in general: qwen not an expert at tool calls and can get stuck with some tasks (like here), but that is more qwen specific

@wendytang wendytang merged commit 91ab336 into main Feb 6, 2025
4 checks passed
@wendytang wendytang deleted the micn/ollama-tool-prompt-tune branch February 6, 2025 17:44
Acumen-Desktop pushed a commit to Acumen-Desktop/goose that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants