Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use SSL_CERT_FILE to point to CA bundle, not for mTLS client cert #1017

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

kalvinnchau
Copy link
Collaborator

use SSL_CERT_FILE to point to the CA cert bundle

https://docs.astral.sh/uv/configuration/authentication/#custom-ca-certificates

If client certificate authentication (mTLS) is desired, set the SSL_CLIENT_CERT

but we want:

If a direct path to the certificate is required (e.g., in CI), set the SSL_CERT_FILE environment variable to the path of the certificate bundle, to instruct uv to use that file instead of the system's trust store.

Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh great catch - originally I was using CERT not client!

@kalvinnchau kalvinnchau merged commit 44bf57b into main Feb 1, 2025
4 checks passed
@kalvinnchau kalvinnchau deleted the kalvin/uvx-ssl branch February 1, 2025 00:33
michaelneale added a commit that referenced this pull request Feb 3, 2025
* main: (23 commits)
  Improve docs & extensions deploy workflow (#996)
  ci: run git tag commands when just tag-push (#1001)
  docs: cleanup (#1035)
  docs: added tutorial template (#1036)
  docs: updated spelling in documentation (#1028)
  really really open markdown links outside (#1002)
  fix: use SSL_CERT_FILE to point to CA bundle, not for mTLS client cert (#1017)
  feat: Add link to github project on extension cards (#1006)
  chore(release): release version 1.0.4 (#1000)
  fix: fix welcome screen azure config submit (#998)
  ci: checkout code to read Cargo.toml for version (#995)
  docs: broken link fix (#994)
  ci: update release processes using Justfile, make reusable workflows have optional version param (#972)
  docs: github tutorial (#993)
  chore: add tests and update url construction for azure provider (#988)
  chore: update docs for ollama endpoint (#992)
  feat: cfg electron to open links in new window (#934)
  fix: improve url construction in provider (#985)
  fix: explicitly add remember_memory tool in the instructions/system prompt (#965)
  feat: add azure openai provider (#960)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants