ci: run git tag commands when just tag-push #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman1993
reviewed
Jan 31, 2025
| @@ -89,12 +89,12 @@ get-tag-version: | |||
|
|
|||
| # create the git tag from Cargo.toml, must be on main | |||
| tag: ensure-main | |||
There was a problem hiding this comment.
the only thing here that we might wanna safeguard against is to compare local HEAD vs remote HEAD cause sometimes folks can forget to pull the change that bumped up the version
There was a problem hiding this comment.
if that's not easy to do i wonder if we can print a msg, hit enter to continue...
There was a problem hiding this comment.
good idea, updated ensure-main to verify both that you're on main and you're on the latest main
which also covers the release version case to makes sure you're cutting a release off the latest main
❯ just tag-push
Error: Your branch is not up to date with the upstream main branch
ensure your branch is up to date (git pull)
error: Recipe `ensure-main` failed with exit code 1
salman1993
approved these changes
Feb 3, 2025
michaelneale
added a commit
that referenced
this pull request
Feb 3, 2025
* main: (23 commits) Improve docs & extensions deploy workflow (#996) ci: run git tag commands when just tag-push (#1001) docs: cleanup (#1035) docs: added tutorial template (#1036) docs: updated spelling in documentation (#1028) really really open markdown links outside (#1002) fix: use SSL_CERT_FILE to point to CA bundle, not for mTLS client cert (#1017) feat: Add link to github project on extension cards (#1006) chore(release): release version 1.0.4 (#1000) fix: fix welcome screen azure config submit (#998) ci: checkout code to read Cargo.toml for version (#995) docs: broken link fix (#994) ci: update release processes using Justfile, make reusable workflows have optional version param (#972) docs: github tutorial (#993) chore: add tests and update url construction for azure provider (#988) chore: update docs for ollama endpoint (#992) feat: cfg electron to open links in new window (#934) fix: improve url construction in provider (#985) fix: explicitly add remember_memory tool in the instructions/system prompt (#965) feat: add azure openai provider (#960) ...
laanak08
pushed a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had
echowhen testing to ensure no false tags were pushed, forgot to remove it