Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Homebrew Cask #1368

Open
1 task done
SalvatoreT opened this issue Feb 24, 2025 · 11 comments
Open
1 task done

Create a Homebrew Cask #1368

SalvatoreT opened this issue Feb 24, 2025 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@SalvatoreT
Copy link

Please explain the motivation behind the feature request.
Allow developers to install/update Goose using a brew install --cask ... command.

Describe the solution you'd like
Add a Homebrew Cask (https://github.com/Homebrew/homebrew-cask).

Describe alternatives you've considered
We could not do this.

Additional context
I'll get this going right now.

  • I have verified this does not duplicate an existing feature request
@SalvatoreT SalvatoreT added the enhancement New feature or request label Feb 24, 2025
SalvatoreT added a commit to SalvatoreT/homebrew-cask that referenced this issue Feb 24, 2025
@SalvatoreT
Copy link
Author

Here's the PR to add the Cask. Homebrew/homebrew-cask#202763

@wendytang
Copy link
Collaborator

wendytang commented Feb 24, 2025

@SalvatoreT thanks for the submission! how to maintain this with version updates?

@SalvatoreT
Copy link
Author

There's a bot that checks repositories for the latest version and bumps the version + checksum automatically. Here's an example: Homebrew/homebrew-cask#202766

SalvatoreT added a commit to SalvatoreT/homebrew-cask that referenced this issue Feb 25, 2025
@wendytang
Copy link
Collaborator

I was able to install goose via brew 👍

@wendytang
Copy link
Collaborator

did you want to add the cli as well? otherwise, i'm happy to add it as a ticket

@SalvatoreT
Copy link
Author

Sure! Do you want the cli as a Homebrew Cask (pre-built/signed by y'all) or via a regular Homebrew package (i.e. built via Homebrew's GitHub actions)?

@wendytang
Copy link
Collaborator

I think we could just use the prebuilt binaries in our release process, so let's do homebrew cask (thanks @damienrj for the input)

@SalvatoreT
Copy link
Author

Hey @wendytang, my mac really doesn't want to run the goose Rust binary.

I tried running it via a Cask and by just downloading the binary from the Release page, and my laptop was not into it.

Image

@SalvatoreT
Copy link
Author

Can y'all sign the Rust binaries in the same way you sign the Desktop app?

@SalvatoreT
Copy link
Author

I have the Cask pretty much ready to go, but I don't want to submit it unless I can run it without the security warning.
Homebrew/homebrew-cask@master...SalvatoreT:homebrew-cask:salvatoret/block-goose-cli

@wendytang
Copy link
Collaborator

let me get the apple_team_id tomorrow. does the binary need to be notarized by apple to run without security warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants