Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicBrainz status is set to noMatches even if request returns a match #635

Open
Unmoon opened this issue Jan 22, 2022 · 2 comments
Open

Comments

@Unmoon
Copy link

Unmoon commented Jan 22, 2022

Opening the link from debug log returns a (correct) release, but for it's treated as no matches. Possibly because it's returning two discs?

Built from 4e7b973

unmoon@debian:~$ /usr/bin/rrip_gui
DEBUG: cdparanoia -d /dev/cdrom -vQ
DEBUG: cd-info -C /dev/cdrom -A --no-cddb
DEBUG: CGI query: https://musicbrainz.org/ws/2/discid/M9kbjJdza5dgQeVMEURn0TyUA4U-?toc=1+17+303484+150+12791+33298+53855+68778+91580+108767+126927+148551+167975+186135+205425+220914+242925+256587+279256+292584&inc=artists+recordings+artist-credits+release-groups
DEBUG: MusicBrainz status after the disc query: noMatches
DEBUG: cd-discid /dev/cdrom
DEBUG: cdrdao read-toc --device /dev/cdrom "/tmp/cdrom.toc"
@irnchkn
Copy link

irnchkn commented May 2, 2023

The code in musicbrainz/getMusicBrainzRelease.rb assumes that releases match this XPath:
//metadata/disc/release-list/release
For some reason, there are some releases which miss out a whole "disc" level, and match this XPath:
//metadata/release-list/release

@irnchkn
Copy link

irnchkn commented May 10, 2023

I spent a while adding some horrible hacks that worked around the XPath problem I described (and seen in Unmoon's example). But eventually I noticed that I didn't actually have cd-info installed. Having installed that (libcdio-utils package in ubuntu) every CD I've tried has been properly identified. But Unmoon appears to have cd-info available.
In cases where multipleRecords are found, I've found it easier to switch to the gtk version and use that to select which one to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants